qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"open list:Block layer core" <qemu-block@nongnu.org>,
	qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL v2 50/50] iotests: Set LC_ALL=C for sort
Date: Sat, 11 Jul 2020 18:07:32 +0100	[thread overview]
Message-ID: <20200711170732.26213-11-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200711170732.26213-1-alex.bennee@linaro.org>

From: Max Reitz <mreitz@redhat.com>

Otherwise the result is basically unpredictable.

(Note that the precise environment variable to control sorting order is
LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
sorting order to be messed up if LC_ALL is set in the environment.)

Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200710163253.381630-3-mreitz@redhat.com>

diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index d967adc59a..c9f978abce 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -186,7 +186,7 @@ _filter_img_create()
             -e 's/^\(data_file\)/3-\1/' \
             -e 's/^\(encryption\)/4-\1/' \
             -e 's/^\(preallocation\)/8-\1/' \
-        | sort \
+        | LC_ALL=C sort \
         | $SED -e 's/^[0-9]-//' \
         | tr '\n\0' ' \n' \
         | $SED -e 's/^ *$//' -e 's/ *$//'
-- 
2.20.1



  parent reply	other threads:[~2020-07-11 17:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-11 17:07 [PULL v2 00/50] testing updates (vm, gitlab, misc build fixes) Alex Bennée
2020-07-11 17:07 ` [PULL v2 04/50] tests/vm: Add configuration to basevm.py Alex Bennée
2020-07-11 17:07 ` [PULL v2 42/50] docs/devel: convert and update MTTCG design document Alex Bennée
2020-07-11 17:07 ` [PULL v2 43/50] docs/devel: add some notes on tcg-icount for developers Alex Bennée
2020-07-11 17:07 ` [PULL v2 44/50] docs: Add to gdbstub documentation the PhyMemMode Alex Bennée
2020-07-11 17:07 ` [PULL v2 45/50] tests/docker: fall back more gracefully when pull fails Alex Bennée
2020-07-11 17:07 ` [PULL v2 46/50] tests/docker: update toolchain set in debian-xtensa-cross Alex Bennée
2020-07-11 17:07 ` [PULL v2 47/50] .cirrus.yml: add bash to the brew packages Alex Bennée
2020-07-11 17:07 ` [PULL v2 48/50] tests: fix "make check-qtest" for modular builds Alex Bennée
2020-07-11 17:07 ` [PULL v2 49/50] Revert "vga: build virtio-gpu as module" Alex Bennée
2020-07-11 17:07 ` Alex Bennée [this message]
2020-07-13  8:34 ` [PULL v2 00/50] testing updates (vm, gitlab, misc build fixes) Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200711170732.26213-11-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).