From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAC5C433E6 for ; Mon, 13 Jul 2020 09:47:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CE16206F0 for ; Mon, 13 Jul 2020 09:47:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KarJaQIo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CE16206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1juv3y-00068U-ME for qemu-devel@archiver.kernel.org; Mon, 13 Jul 2020 05:47:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1juv2p-0005Tg-M8 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 05:46:43 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:49847 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1juv2n-0000bo-B7 for qemu-devel@nongnu.org; Mon, 13 Jul 2020 05:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594633600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B0Oe5UV2qyeUG9Z0o/6/qc3LlnZaZG6gs7b/Di/jHF4=; b=KarJaQIo1zHWIl/CsbwDzNwl5/BAlK256h/dXO5BJK5uz3ztgCUP26nhOQWx2SWA7tLGN5 jp6kBhjC1SF/gcwfRjFXu2JObjzx/DaiV7H0GWxIylUbBe6SkqYDmu68zxRQQd3Mh6Hy2a 6w6xwWwPUPKg4iwzdkxcwBqe46RUkik= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-SmNjCEALNaCu-3G69JToMA-1; Mon, 13 Jul 2020 05:46:38 -0400 X-MC-Unique: SmNjCEALNaCu-3G69JToMA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6DB3E8015F4; Mon, 13 Jul 2020 09:46:34 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-115-89.ams2.redhat.com [10.36.115.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 303A327DE7C; Mon, 13 Jul 2020 09:46:24 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1CA893EBB1; Mon, 13 Jul 2020 11:46:24 +0200 (CEST) Date: Mon, 13 Jul 2020 11:46:24 +0200 From: Gerd Hoffmann To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 00/26] hw/usb: Give it love, reduce 'hw/usb.h' inclusion out of hw/usb/ Message-ID: <20200713094624.occmvxdb56kvbqy2@sirius.home.kraxel.org> References: <20200704144943.18292-1-f4bug@amsat.org> MIME-Version: 1.0 In-Reply-To: <20200704144943.18292-1-f4bug@amsat.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/13 01:36:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , "Edgar E. Iglesias" , Huacai Chen , Stefano Stabellini , xen-devel@lists.xenproject.org, Yoshinori Sato , Paul Durrant , Magnus Damm , Markus Armbruster , =?utf-8?B?SGVydsOp?= Poussineau , Anthony Perard , Samuel Thibault , Leif Lindholm , Aleksandar Rikalo , Eduardo Habkost , Alistair Francis , "Dr. David Alan Gilbert" , Beniamino Galvani , Niek Linnenbank , qemu-arm@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Radoslaw Biernacki , Igor Mitsyanko , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paul Zimmerman , qemu-ppc@nongnu.org, David Gibson , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Jul 04, 2020 at 04:49:17PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > This is the second time I try to replace a magic typename string > by a constant, and Zoltan warns me this is counter productive as > "hw/usb.h" pulls in an insane amount of code. > > Time to give the usb subsystem some love and move forward. > > This series can be decomposed as follow: > > 1-2: preliminary machine cleanups (arm/ppc) > 3-13: usb related headers cleanups > 14-15: usb quirks cleanup > 16-18: refactor usb_get_dev_path() to add usb_get_port_path() > 19: let spapr use usb_get_port_path() to make USBDevice opaque > 20: extract the public USB API (for machine/board/soc) > 21: make the older "usb.h" internal to hw/usb/ > 22-25: use TYPENAME definitions > 26: cover dwc2 in MAINTAINERS > > Please review. Looks good overall, I don't fell like squeezing this into 5.1 though. Can you repost (with the few comments addressed) once 5.2 is open for development in roughly a month? thanks, Gerd