From: Thomas Huth <thuth@redhat.com>
To: peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: Alexander Bulekov <alxndr@bu.edu>
Subject: [PULL 2/9] configure: do not clobber CFLAGS with --enable-fuzzing
Date: Mon, 13 Jul 2020 12:55:27 +0200 [thread overview]
Message-ID: <20200713105534.10872-3-thuth@redhat.com> (raw)
In-Reply-To: <20200713105534.10872-1-thuth@redhat.com>
From: Alexander Bulekov <alxndr@bu.edu>
When configuring with --enable-fuzzing, we overwrote the CFLAGS
added by all the preceding checks. Instead of overwriting CFLAGS, append
the ones we need.
Fixes: adc28027ff ("fuzz: add configure flag --enable-fuzzing")
Reported-by: Li Qiang <liq3ea@163.com>
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Message-Id: <20200708200104.21978-2-alxndr@bu.edu>
Tested-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index f59418f6de..69a89113f7 100755
--- a/configure
+++ b/configure
@@ -7926,7 +7926,7 @@ if test "$fuzzing" = "yes" ; then
if test "$have_fuzzer" = "yes"; then
FUZZ_LDFLAGS=" -fsanitize=address,fuzzer"
FUZZ_CFLAGS=" -fsanitize=address,fuzzer"
- CFLAGS=" -fsanitize=address,fuzzer-no-link"
+ CFLAGS="$CFLAGS -fsanitize=address,fuzzer-no-link"
else
error_exit "Your compiler doesn't support -fsanitize=address,fuzzer"
exit 1
--
2.18.1
next prev parent reply other threads:[~2020-07-13 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 10:55 [PULL 0/9] Fuzzer, configure, gitlab and misc patches Thomas Huth
2020-07-13 10:55 ` [PULL 1/9] configure: fix malloc check Thomas Huth
2020-07-13 10:55 ` Thomas Huth [this message]
2020-07-13 10:55 ` [PULL 3/9] fuzz: add missing header for rcu_enable_atfork Thomas Huth
2020-07-13 10:55 ` [PULL 4/9] tests/qtest/fuzz: Add missing spaces in description Thomas Huth
2020-07-13 10:55 ` [PULL 5/9] docs/devel/fuzzing: Fix bugs in documentation Thomas Huth
2020-07-13 10:55 ` [PULL 6/9] Remove the CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE switch Thomas Huth
2020-07-13 10:55 ` [PULL 7/9] disas/sh4: Add missing fallthrough annotations Thomas Huth
2020-07-13 10:55 ` [PULL 8/9] GitLab Gating CI: introduce pipeline-status contrib script Thomas Huth
2020-07-13 10:55 ` [PULL 9/9] docs/system/s390x: Improve the 3270 documentation Thomas Huth
2020-07-13 11:27 ` [PULL 0/9] Fuzzer, configure, gitlab and misc patches no-reply
2020-07-13 13:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713105534.10872-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alxndr@bu.edu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).