qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Josh Kunz <jkz@google.com>, Laurent Vivier <laurent@vivier.eu>
Subject: [PULL 1/7] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols
Date: Tue, 14 Jul 2020 09:32:53 +0200	[thread overview]
Message-ID: <20200714073259.1464675-2-laurent@vivier.eu> (raw)
In-Reply-To: <20200714073259.1464675-1-laurent@vivier.eu>

From: Josh Kunz <jkz@google.com>

Linux uses the EPROTONOSUPPORT error code[1] if the users requests a
netlink socket with an unsupported netlink protocol. This change
switches linux-user to use the same code as Linux, instead of
EPFNOSUPPORT (which AFAIK is just an anachronistic version of
EAFNOSUPPORT).

Tested by compiling all linux-user targets on x86.

[1]:
https://github.com/torvalds/linux/blob/bfe91da29bfad9941d5d703d45e29f0812a20724/net/netlink/af_netlink.c#L683

Signed-off-by: Josh Kunz <jkz@google.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200707001036.1671982-1-jkz@google.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 98ea86ca81fb..e9f53340cd65 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -2990,7 +2990,7 @@ static abi_long do_socket(int domain, int type, int protocol)
 #endif
          protocol == NETLINK_KOBJECT_UEVENT ||
          protocol == NETLINK_AUDIT)) {
-        return -TARGET_EPFNOSUPPORT;
+        return -TARGET_EPROTONOSUPPORT;
     }
 
     if (domain == AF_PACKET ||
-- 
2.26.2



  reply	other threads:[~2020-07-14  7:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  7:32 [PULL 0/7] Linux user for 5.1 patches Laurent Vivier
2020-07-14  7:32 ` Laurent Vivier [this message]
2020-07-14  7:32 ` [PULL 2/7] linux-user: refactor ipc syscall and support of semtimedop syscall Laurent Vivier
2020-07-14  7:32 ` [PULL 3/7] linux-user: Fix Coverity CID 1430271 / CID 1430272 Laurent Vivier
2020-07-14  7:32 ` [PULL 4/7] linux-user: add new netlink types Laurent Vivier
2020-07-14  7:32 ` [PULL 5/7] linux-user: add netlink RTM_SETLINK command Laurent Vivier
2020-07-14  7:32 ` [PULL 6/7] linux-user: fix the errno value in print_syscall_err() Laurent Vivier
2020-07-14  7:32 ` [PULL 7/7] linux-user: fix print_syscall_err() when syscall returned value is negative Laurent Vivier
2020-07-14  7:59 ` [PULL 0/7] Linux user for 5.1 patches no-reply
2020-07-14 20:21 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714073259.1464675-2-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=jkz@google.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).