qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	Filip.Bozuta@syrmia.com,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PULL 6/7] linux-user: fix the errno value in print_syscall_err()
Date: Tue, 14 Jul 2020 09:32:58 +0200	[thread overview]
Message-ID: <20200714073259.1464675-7-laurent@vivier.eu> (raw)
In-Reply-To: <20200714073259.1464675-1-laurent@vivier.eu>

errno of the target is returned as a negative value by the syscall,
not in the host errno variable.

The emulation of the target syscall can return an error while the
host doesn't set an errno value. Target errnos and host errnos can
also differ in some cases.

Fixes: c84be71f6854 ("linux-user: Extend strace support to enable argument printing after syscall execution")
Cc: Filip.Bozuta@syrmia.com
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
Message-Id: <20200708152435.706070-2-laurent@vivier.eu>
---
 linux-user/strace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 39554d903911..7769f53bd5ed 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -731,7 +731,7 @@ print_syscall_err(abi_long ret)
 
     qemu_log(" = ");
     if (ret < 0) {
-        qemu_log("-1 errno=%d", errno);
+        qemu_log("-1 errno=%d", (int)-ret);
         errstr = target_strerror(-ret);
         if (errstr) {
             qemu_log(" (%s)", errstr);
-- 
2.26.2



  parent reply	other threads:[~2020-07-14  7:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  7:32 [PULL 0/7] Linux user for 5.1 patches Laurent Vivier
2020-07-14  7:32 ` [PULL 1/7] linux-user: Use EPROTONOSUPPORT for unimplemented netlink protocols Laurent Vivier
2020-07-14  7:32 ` [PULL 2/7] linux-user: refactor ipc syscall and support of semtimedop syscall Laurent Vivier
2020-07-14  7:32 ` [PULL 3/7] linux-user: Fix Coverity CID 1430271 / CID 1430272 Laurent Vivier
2020-07-14  7:32 ` [PULL 4/7] linux-user: add new netlink types Laurent Vivier
2020-07-14  7:32 ` [PULL 5/7] linux-user: add netlink RTM_SETLINK command Laurent Vivier
2020-07-14  7:32 ` Laurent Vivier [this message]
2020-07-14  7:32 ` [PULL 7/7] linux-user: fix print_syscall_err() when syscall returned value is negative Laurent Vivier
2020-07-14  7:59 ` [PULL 0/7] Linux user for 5.1 patches no-reply
2020-07-14 20:21 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714073259.1464675-7-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=Filip.Bozuta@syrmia.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).