From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
den@openvz.org
Subject: [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak
Date: Tue, 14 Jul 2020 19:22:32 +0300 [thread overview]
Message-ID: <20200714162234.13113-1-vsementsov@virtuozzo.com> (raw)
Hi all!
We've faced crash bug, which is reproducing on master branch as well.
The case is described in 01, where fix is suggested.
New iotest in 02 crashes without that fix.
v3: resend for convenience, as all preparatory patches are merged.
01-02: add Eric's r-b and t-b marks
====
This is a crash-fix, so it would be good to fix in 5.1. Still neither
Eric nor I are sure in patch 01: is AIO_WAIT_WHILE used correctly?
====
Side note: this AIO_WAIT_WHILE may be long, if nbd reconnect is enabled
and connection failed recently. Still it's another story: I think we
actually should disable reconnect in bdrv_close, before drain.
Vladimir Sementsov-Ogievskiy (2):
nbd: make nbd_export_close_all() synchronous
iotests: test shutdown when bitmap is exported through NBD
nbd/server.c | 8 +++++
tests/qemu-iotests/299 | 65 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/299.out | 10 ++++++
tests/qemu-iotests/group | 1 +
4 files changed, 84 insertions(+)
create mode 100644 tests/qemu-iotests/299
create mode 100644 tests/qemu-iotests/299.out
--
2.21.0
next reply other threads:[~2020-07-14 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 16:22 Vladimir Sementsov-Ogievskiy [this message]
2020-07-14 16:22 ` [PATCH v3 1/2] nbd: make nbd_export_close_all() synchronous Vladimir Sementsov-Ogievskiy
2020-07-14 16:22 ` [PATCH v3 2/2] iotests: test shutdown when bitmap is exported through NBD Vladimir Sementsov-Ogievskiy
2020-07-14 16:49 ` [PATCH v3 for-5.1 0/2] Fix crash due to NBD export leak no-reply
2020-07-14 16:59 ` Vladimir Sementsov-Ogievskiy
2020-07-14 17:26 ` Philippe Mathieu-Daudé
2020-07-17 12:01 ` Kevin Wolf
2020-07-17 15:00 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714162234.13113-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).