From: Gerd Hoffmann <kraxel@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vfio: fix use-after-free in display
Date: Wed, 15 Jul 2020 12:40:18 +0200 [thread overview]
Message-ID: <20200715104018.2f5og5mgikacxfp5@sirius.home.kraxel.org> (raw)
In-Reply-To: <20200713145340.4886d664@x1.home>
Hi,
> Tricky, but I think I follow that dpy->region.surface is only ever
> allocated to replace dpy->con->surface, so when ramfb_display_update()
> then replaces and frees dpy->con->surface with dpy->ramfb->ds, that's
> where the object point to by dpy->region.surface was freed. Right?
Correct.
> If so, looks ok to me. If you're constructing a pull request, I'll
> give you an:
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
> Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
>
> If you need me to send a pull, let me know.
I'll go create a pull req, I have one or two other patches pending
anyway.
take care,
Gerd
prev parent reply other threads:[~2020-07-15 10:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:45 [PATCH] vfio: fix use-after-free in display Gerd Hoffmann
2020-07-13 12:51 ` Philippe Mathieu-Daudé
2020-07-13 14:00 ` Gerd Hoffmann
2020-07-13 14:09 ` Philippe Mathieu-Daudé
2020-07-13 20:53 ` Alex Williamson
2020-07-15 10:40 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715104018.2f5og5mgikacxfp5@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).