From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Cameron Esfahani" <dirty@apple.com>
Subject: Re: [PATCH 3/4] build: Don't make object files for dtrace on macOS
Date: Thu, 16 Jul 2020 09:54:59 +0100 [thread overview]
Message-ID: <20200716085459.GC227735@redhat.com> (raw)
In-Reply-To: <20200716081754.22422-4-r.bolshakov@yadro.com>
On Thu, Jul 16, 2020 at 11:17:53AM +0300, Roman Bolshakov wrote:
> dtrace on macOS uses unresolved symbols with a special prefix to define
> probes [1], only headers should be generated for USDT (dtrace(1)). But
> it doesn't support backwards compatible no-op -G flag [2] and implicit
> build rules fail.
>
> 1. https://markmail.org/message/6grq2ygr5nwdwsnb
> 2. https://markmail.org/message/5xrxt2w5m42nojkz
>
> Cc: Cameron Esfahani <dirty@apple.com>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
> Makefile.objs | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-16 8:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:17 [PATCH 0/4] Add dtrace support on macOS Roman Bolshakov
2020-07-16 8:17 ` [PATCH 1/4] scripts/tracetool: Fix dtrace generation for macOS Roman Bolshakov
2020-07-16 8:56 ` Daniel P. Berrangé
2020-07-16 8:17 ` [PATCH 2/4] scripts/tracetool: Use void pointer for vcpu Roman Bolshakov
2020-07-16 8:57 ` Daniel P. Berrangé
2020-07-16 8:17 ` [PATCH 3/4] build: Don't make object files for dtrace on macOS Roman Bolshakov
2020-07-16 8:54 ` Daniel P. Berrangé [this message]
2020-07-16 8:17 ` [PATCH 4/4] net/colo: Match is-enabled probe to tracepoint Roman Bolshakov
2020-07-16 8:51 ` Daniel P. Berrangé
2020-07-16 10:55 ` Roman Bolshakov
2020-07-16 8:55 ` [PATCH 0/4] Add dtrace support on macOS Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716085459.GC227735@redhat.com \
--to=berrange@redhat.com \
--cc=dirty@apple.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).