From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH 01/18] migration/vmstate: Document vmstate_dummy
Date: Thu, 16 Jul 2020 10:22:00 +0100 [thread overview]
Message-ID: <20200716092200.GB2687@work-vm> (raw)
In-Reply-To: <20200703201911.26573-2-f4bug@amsat.org>
* Philippe Mathieu-Daudé (f4bug@amsat.org) wrote:
> vmstate_dummy is special and restricted to linux-user. See commit
> c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY").
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/migration/vmstate.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index f68ed7db13..af7d80cd4e 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -194,7 +194,7 @@ struct VMStateDescription {
> const VMStateDescription **subsections;
> };
>
> -extern const VMStateDescription vmstate_dummy;
> +extern const VMStateDescription vmstate_dummy; /* Exclusively for linux-user */
Which does mean it's a unfortunate name I guess for something so
specific.
(It's also very weird having a vmsd defined with no VMSTATE_END_OF_LIST
marker).
Dave
> extern const VMStateInfo vmstate_info_bool;
>
> --
> 2.21.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-07-16 9:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 20:18 [PATCH 00/18] hw: Mark the device with no migratable fields Philippe Mathieu-Daudé
2020-07-03 20:18 ` [PATCH 01/18] migration/vmstate: Document vmstate_dummy Philippe Mathieu-Daudé
2020-07-16 9:22 ` Dr. David Alan Gilbert [this message]
2020-07-16 9:52 ` Daniel P. Berrangé
2020-07-16 10:00 ` Philippe Mathieu-Daudé
2020-07-03 20:18 ` [PATCH 02/18] migration/vmstate: Introduce vmstate_no_state_to_migrate Philippe Mathieu-Daudé
2020-07-09 19:00 ` Peter Maydell
2020-08-05 10:47 ` Dr. David Alan Gilbert
2020-07-03 20:18 ` [PATCH 03/18] hw/core/qdev: Add vmstate_qdev_no_state_to_migrate Philippe Mathieu-Daudé
2020-07-03 20:18 ` [PATCH 04/18] hw/arm/armv7m: Mark the device with no migratable fields Philippe Mathieu-Daudé
2020-07-09 19:03 ` Peter Maydell
2020-07-03 20:18 ` [PATCH 05/18] hw/arm/aspeed_soc: " Philippe Mathieu-Daudé
2020-07-03 20:18 ` [PATCH 06/18] hw/arm/bcm283x: Mark devices " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 07/18] hw/arm/msf2-soc: Mark the device " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 08/18] hw/core/split-irq: " Philippe Mathieu-Daudé
2020-07-09 19:04 ` Peter Maydell
2020-07-03 20:19 ` [PATCH 09/18] hw/cpu/a9mpcore: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 10/18] hw/cpu/cluster: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 11/18] hw/usb/hcd-ohci: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 12/18] hw/intc/arm_gicv2m: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 13/18] hw/misc/armsse-cpuid: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 14/18] hw/misc/iotkit-sysinfo: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 15/18] hw/misc/unimp: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 16/18] hw/nubus/mac-nubus-bridge: " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [PATCH 17/18] hw/sparc64/sun4u: Mark devices " Philippe Mathieu-Daudé
2020-07-03 20:19 ` [RFC PATCH 18/18] hw/core/qdev: Display warning for devices missing migration state Philippe Mathieu-Daudé
2020-07-09 19:14 ` Peter Maydell
2021-01-17 17:28 ` Philippe Mathieu-Daudé
2020-07-03 21:02 ` [PATCH 00/18] hw: Mark the device with no migratable fields no-reply
2020-07-09 19:19 ` Peter Maydell
2021-01-14 15:49 ` Philippe Mathieu-Daudé
2021-01-18 7:33 ` Laurent Vivier
2021-01-18 9:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716092200.GB2687@work-vm \
--to=dgilbert@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=andrew@aj.id.au \
--cc=atar4qemu@gmail.com \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=joel@jms.id.au \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).