From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Reitz" <mreitz@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, "John Snow" <jsnow@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev()
Date: Thu, 16 Jul 2020 14:37:03 +0200 [thread overview]
Message-ID: <20200716123704.6557-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200716123704.6557-1-f4bug@amsat.org>
Add a trace event to follow devices attaching block drives:
$ qemu-system-arm -M n800 -trace blk_\*
9513@1594040428.738162:blk_attach_dev attaching blk 'sd0' to device 'omap2-mmc'
9513@1594040428.738189:blk_attach_dev attaching blk 'sd0' to device 'sd-card'
qemu-system-arm: sd_init failed: blk 'sd0' already attached by device 'sd-card'
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
block/block-backend.c | 1 +
block/trace-events | 1 +
2 files changed, 2 insertions(+)
diff --git a/block/block-backend.c b/block/block-backend.c
index 0bf0188133..63ff940ef9 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -888,6 +888,7 @@ void blk_get_perm(BlockBackend *blk, uint64_t *perm, uint64_t *shared_perm)
*/
int blk_attach_dev(BlockBackend *blk, DeviceState *dev)
{
+ trace_blk_attach_dev(blk_name(blk), object_get_typename(OBJECT(dev)));
if (blk->dev) {
return -EBUSY;
}
diff --git a/block/trace-events b/block/trace-events
index dbe76a7613..aa641c2034 100644
--- a/block/trace-events
+++ b/block/trace-events
@@ -9,6 +9,7 @@ blk_co_preadv(void *blk, void *bs, int64_t offset, unsigned int bytes, int flags
blk_co_pwritev(void *blk, void *bs, int64_t offset, unsigned int bytes, int flags) "blk %p bs %p offset %"PRId64" bytes %u flags 0x%x"
blk_root_attach(void *child, void *blk, void *bs) "child %p blk %p bs %p"
blk_root_detach(void *child, void *blk, void *bs) "child %p blk %p bs %p"
+blk_attach_dev(const char *blk_name, const char *dev_name) "attaching blk '%s' to device '%s'"
# io.c
bdrv_co_preadv(void *bs, int64_t offset, int64_t nbytes, unsigned int flags) "bs %p offset %"PRId64" nbytes %"PRId64" flags 0x%x"
--
2.21.3
next prev parent reply other threads:[~2020-07-16 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:37 [PATCH-for-5.2 v2 0/2] block/block-backend: Let blk_attach_dev() provide helpful error Philippe Mathieu-Daudé
2020-07-16 12:37 ` Philippe Mathieu-Daudé [this message]
2020-07-16 12:42 ` [PATCH-for-5.2 v2 1/2] block/block-backend: Trace blk_attach_dev() Philippe Mathieu-Daudé
2020-07-16 12:37 ` [RFC PATCH-for-5.2 v2 2/2] block/block-backend: Let blk_attach_dev() provide helpful error Philippe Mathieu-Daudé
2020-07-16 13:04 ` Daniel P. Berrangé
2020-07-17 5:32 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716123704.6557-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=mreitz@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).