From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [PATCH for-5.1 v2 0/2] qemu-img convert: Fix abort with unaligned image size
Date: Thu, 16 Jul 2020 16:25:59 +0200 [thread overview]
Message-ID: <20200716142601.111237-1-kwolf@redhat.com> (raw)
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1834646
Patch 1 fixes the assertion failure by failing gracefully when opening
an image whose size isn't aligned to the required request alignment.
Patch 2 relaxes the restrictions for NFS, which actually supports byte
alignment, but incorrectly gets a 4k request alignment in the file-posix
block driver.
v2:
- Don't fail opening unaligned images, but requesting WRITE permission
without RESIZE. This keeps qcow2 images with unaligned metadata at EOF
working. [Max]
Kevin Wolf (2):
block: Require aligned image size to avoid assertion failure
file-posix: Allow byte-aligned O_DIRECT with NFS
block.c | 16 ++++++++++++++++
block/file-posix.c | 26 +++++++++++++++++++++++++-
2 files changed, 41 insertions(+), 1 deletion(-)
--
2.25.4
next reply other threads:[~2020-07-16 14:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 14:25 Kevin Wolf [this message]
2020-07-16 14:26 ` [PATCH for-5.1 v2 1/2] block: Require aligned image size to avoid assertion failure Kevin Wolf
2020-07-17 11:02 ` Max Reitz
2020-07-17 11:32 ` Kevin Wolf
2020-07-17 11:36 ` Max Reitz
2020-07-16 14:26 ` [PATCH for-5.1 v2 2/2] file-posix: Allow byte-aligned O_DIRECT with NFS Kevin Wolf
2020-07-17 11:15 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716142601.111237-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).