From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08D3BC433E1 for ; Thu, 16 Jul 2020 13:07:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C70EF20760 for ; Thu, 16 Jul 2020 13:06:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IRI99qKx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C70EF20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw3bH-0005zY-1I for qemu-devel@archiver.kernel.org; Thu, 16 Jul 2020 09:06:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw3aN-0004tY-Kh for qemu-devel@nongnu.org; Thu, 16 Jul 2020 09:06:03 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:57808 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jw3aM-0007sC-0o for qemu-devel@nongnu.org; Thu, 16 Jul 2020 09:06:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594904761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xRcBudkig0CHxkDINv9gCJPiWE7iKzDOqeQhLg2MgUA=; b=IRI99qKxlJ9fisjF9icR7d1dmMTvxI3iUzgz3WBCMgtLfgBpk/eypcWyfFmWRLLZzDg9Ew HzlLlArk26FDNT8YXpxsLiNg+QyzZd4WwPrcp8diLD3c6/10jlcwEHHxVOOWZl1D0Am6hF Or0yR6DfOop7BDieINSBIMS0EqE+6GY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-wUL5lP-JOGGuY9CpscWK3w-1; Thu, 16 Jul 2020 09:05:59 -0400 X-MC-Unique: wUL5lP-JOGGuY9CpscWK3w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2887D1940920; Thu, 16 Jul 2020 13:05:58 +0000 (UTC) Received: from localhost (unknown [10.40.208.75]) by smtp.corp.redhat.com (Postfix) with ESMTP id A130E7B408; Thu, 16 Jul 2020 13:05:45 +0000 (UTC) Date: Thu, 16 Jul 2020 15:05:41 +0200 From: Igor Mammedov To: Gerd Hoffmann Subject: Re: [PATCH v5 19/20] tests/acpi: add microvm test Message-ID: <20200716150541.3f8c64e1@redhat.com> In-Reply-To: <20200716091035.xkgp42f56t7eohjt@sirius.home.kraxel.org> References: <20200707125356.32450-1-kraxel@redhat.com> <20200707125356.32450-20-kraxel@redhat.com> <20200710214958.36978f12@redhat.com> <20200716091035.xkgp42f56t7eohjt@sirius.home.kraxel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/16 04:55:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 16 Jul 2020 11:10:35 +0200 Gerd Hoffmann wrote: > Hi, > > > > + data.required_struct_types = base_required_struct_types; > > > + data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types); > > I vaguely recall this belongs to smbios tables, does actually microvm provide them? > > Checked. Yes, it tests smbios tables. > > seabios generates something in case qemu doesn't provide smbios tables, > so the test works. We don't actually test qemu though, so it probably > makes sense to drop that for microvm until we actually generate smbios > tables. Should we? if dropping it just works, then yes, otherwise I wouldn't bother. > > take care, > Gerd >