qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	Cameron Esfahani <dirty@apple.com>,
	Roman Bolshakov <r.bolshakov@yadro.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: [PULL 2/6] i386/cpu: Don't add unavailable_features to env->user_features
Date: Thu, 16 Jul 2020 14:18:59 -0400	[thread overview]
Message-ID: <20200716181903.1895314-3-ehabkost@redhat.com> (raw)
In-Reply-To: <20200716181903.1895314-1-ehabkost@redhat.com>

From: Xiaoyao Li <xiaoyao.li@intel.com>

Features unavailable due to absent of their dependent features should
not be added to env->user_features. env->user_features only contains the
feature explicity specified with -feature/+feature by user.

Fixes: 99e24dbdaa68 ("target/i386: introduce generic feature dependency mechanism")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Message-Id: <20200713174436.41070-3-xiaoyao.li@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 target/i386/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index caf0334f3a..93b62b2eca 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6371,7 +6371,6 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp)
                                       unavailable_features & env->user_features[d->to.index],
                                       "This feature depends on other features that were not requested");
 
-            env->user_features[d->to.index] |= unavailable_features;
             env->features[d->to.index] &= ~unavailable_features;
         }
     }
-- 
2.26.2



  parent reply	other threads:[~2020-07-16 18:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 18:18 [PULL 0/6] x86 fixes for -rc1 Eduardo Habkost
2020-07-16 18:18 ` [PULL 1/6] i368/cpu: Clear env->user_features after loading versioned CPU model Eduardo Habkost
2020-07-16 18:18 ` Eduardo Habkost [this message]
2020-07-16 18:19 ` [PULL 3/6] target/i386: add fast short REP MOV support Eduardo Habkost
2020-07-16 18:19 ` [PULL 4/6] target/i386: fix model number and add missing features for Icelake-Server CPU model Eduardo Habkost
2020-07-16 18:19 ` [PULL 5/6] target/i386: add the missing vmx features for Skylake-Server and Cascadelake-Server CPU models Eduardo Habkost
2020-07-16 18:19 ` [PULL 6/6] i386: hvf: Explicitly set CR4 guest/host mask Eduardo Habkost
2020-07-17  9:38 ` [PULL 0/6] x86 fixes for -rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716181903.1895314-3-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=dirty@apple.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=rth@twiddle.net \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).