From: Alex Williamson <alex.williamson@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Prasad J Pandit" <pjp@fedoraproject.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li Qiang" <liq3ea@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"P J P" <ppandit@redhat.com>, "Lei Sun" <slei.casper@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 3/9] vfio: add quirk device write method
Date: Fri, 17 Jul 2020 09:53:52 -0600 [thread overview]
Message-ID: <20200717095352.45845d8a@x1.home> (raw)
In-Reply-To: <CAFEAcA-1EhD=0vU1r=48HhFPpovns2M5DBgTu7g2074kueaEuw@mail.gmail.com>
On Thu, 16 Jul 2020 18:46:33 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On Tue, 30 Jun 2020 at 13:30, P J P <ppandit@redhat.com> wrote:
> >
> > From: Prasad J Pandit <pjp@fedoraproject.org>
> >
> > Add vfio quirk device mmio write method to avoid NULL pointer
> > dereference issue.
> >
> > Reported-by: Lei Sun <slei.casper@gmail.com>
> > Reviewed-by: Li Qiang <liq3ea@gmail.com>
> > Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
> > ---
> > hw/vfio/pci-quirks.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > Update v3: Add Reviewed-by: ...
> > -> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg09406.html
> >
> > diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> > index d304c81148..cc6d5dbc23 100644
> > --- a/hw/vfio/pci-quirks.c
> > +++ b/hw/vfio/pci-quirks.c
> > @@ -14,6 +14,7 @@
> > #include "config-devices.h"
> > #include "exec/memop.h"
> > #include "qemu/units.h"
> > +#include "qemu/log.h"
> > #include "qemu/error-report.h"
> > #include "qemu/main-loop.h"
> > #include "qemu/module.h"
> > @@ -264,8 +265,15 @@ static uint64_t vfio_ati_3c3_quirk_read(void *opaque,
> > return data;
> > }
> >
> > +static void vfio_ati_3c3_quirk_write(void *opaque, hwaddr addr,
> > + uint64_t data, unsigned size)
> > +{
> > + qemu_log_mask(LOG_GUEST_ERROR, "%s not implemented\n", __func__);
> > +}
> > +
> > static const MemoryRegionOps vfio_ati_3c3_quirk = {
> > .read = vfio_ati_3c3_quirk_read,
> > + .write = vfio_ati_3c3_quirk_write,
> > .endianness = DEVICE_LITTLE_ENDIAN,
> > };
>
>
> Alex (Williamson) -- as the vfio maintainer, do you have a view
> on whether we should be logging write accesses to port 0x3c3
> here as guest-errors or unimplemented-QEMU-functionality?
>
> Guest-error seems plausible to me, anyway.
I believe the intention was that writes would be dropped, so if this
generates logging that is going to cause users to file bugs, that would
be undesirable. Thanks,
Alex
next prev parent reply other threads:[~2020-07-17 15:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 12:27 [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks P J P
2020-06-30 12:27 ` [PATCH v3 1/9] hw/pci-host: add pci-intack write method P J P
2020-07-16 17:34 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 2/9] pci-host: add pcie-msi read method P J P
2020-07-16 16:54 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 3/9] vfio: add quirk device write method P J P
2020-07-16 17:46 ` Peter Maydell
2020-07-17 15:53 ` Alex Williamson [this message]
2020-07-17 15:57 ` Peter Maydell
2020-07-17 16:23 ` Alex Williamson
2020-06-30 12:27 ` [PATCH v3 4/9] prep: add ppc-parity " P J P
2020-06-30 12:27 ` [PATCH v3 5/9] nvram: add nrf51_soc flash read method P J P
2020-07-16 16:29 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 6/9] spapr_pci: add spapr msi " P J P
2020-07-16 16:38 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 7/9] tz-ppc: add dummy read/write methods P J P
2020-06-30 12:34 ` Philippe Mathieu-Daudé
2020-07-01 1:23 ` Li Qiang
2020-07-16 16:09 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 8/9] imx7-ccm: add digprog mmio write method P J P
2020-07-16 16:21 ` Peter Maydell
2020-07-16 16:55 ` P J P
2020-07-16 16:56 ` Peter Maydell
2020-06-30 12:27 ` [PATCH v3 9/9] memory: assert MemoryRegionOps callbacks are defined P J P
2020-07-16 17:33 ` Peter Maydell
2020-06-30 13:46 ` [PATCH v3 0/9] memory: assert and define MemoryRegionOps callbacks no-reply
2020-07-13 18:58 ` P J P
2020-07-13 19:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717095352.45845d8a@x1.home \
--to=alex.williamson@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slei.casper@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).