qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	richard.henderson@linaro.org, f4bug@amsat.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"KONRAD Frederic" <frederic.konrad@adacore.com>,
	cota@braap.org, aurelien@aurel32.net
Subject: [PATCH  v1 3/5] semihosting: don't send the trailing '\0'
Date: Fri, 17 Jul 2020 11:51:37 +0100	[thread overview]
Message-ID: <20200717105139.25293-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200717105139.25293-1-alex.bennee@linaro.org>

From: KONRAD Frederic <frederic.konrad@adacore.com>

Don't send the trailing 0 from the string.

Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <1592215252-26742-2-git-send-email-frederic.konrad@adacore.com>
---
 hw/semihosting/console.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
index 22e7827824a..9b4fee92602 100644
--- a/hw/semihosting/console.c
+++ b/hw/semihosting/console.c
@@ -52,7 +52,9 @@ static GString *copy_user_string(CPUArchState *env, target_ulong addr)
 
     do {
         if (cpu_memory_rw_debug(cpu, addr++, &c, 1, 0) == 0) {
-            s = g_string_append_c(s, c);
+            if (c) {
+                s = g_string_append_c(s, c);
+            }
         } else {
             qemu_log_mask(LOG_GUEST_ERROR,
                           "%s: passed inaccessible address " TARGET_FMT_lx,
-- 
2.20.1



  parent reply	other threads:[~2020-07-17 10:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 10:51 [PATCH v1 0/5] candidate fixes for 5.1-rc1 (shippable, semihosting, OOM tcg) Alex Bennée
2020-07-17 10:51 ` [PATCH v1 1/5] shippable: add one more qemu to registry url Alex Bennée
2020-07-17 19:41   ` Philippe Mathieu-Daudé
2020-07-17 10:51 ` [PATCH v1 2/5] semihosting: defer connect_chardevs a little more to use serialx Alex Bennée
2020-07-17 17:41   ` Richard Henderson
2020-07-17 10:51 ` Alex Bennée [this message]
2020-07-17 17:47   ` [PATCH v1 3/5] semihosting: don't send the trailing '\0' Richard Henderson
2020-07-17 10:51 ` [PATCH v1 4/5] util: add qemu_get_host_physmem utility function Alex Bennée
2020-07-17 13:32   ` BALATON Zoltan
2020-07-17 14:24     ` Christian Ehrhardt
2020-07-17 18:00       ` Richard Henderson
2020-07-21 13:50         ` Alex Bennée
2020-07-17 18:05   ` Richard Henderson
2020-07-21 15:58     ` Alex Bennée
2020-07-17 10:51 ` [PATCH v1 5/5] accel/tcg: better handle memory constrained systems Alex Bennée
2020-07-17 14:23   ` Christian Ehrhardt
2020-07-17 14:39   ` Daniel P. Berrangé
2020-07-17 14:55     ` Alex Bennée
2020-07-17 15:00       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717105139.25293-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=frederic.konrad@adacore.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).