From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6BBC433DF for ; Fri, 17 Jul 2020 14:19:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B02BE206BE for ; Fri, 17 Jul 2020 14:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UBqeIPJk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B02BE206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jwRCa-0003FG-Vt for qemu-devel@archiver.kernel.org; Fri, 17 Jul 2020 10:19:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jwRBp-0002nR-Ml for qemu-devel@nongnu.org; Fri, 17 Jul 2020 10:18:18 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:45835 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jwRBl-0007Q1-PW for qemu-devel@nongnu.org; Fri, 17 Jul 2020 10:18:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594995492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6nG6J4YezlYfGUG0e0ERTOm/9YYwGefzHEeAhTeysKE=; b=UBqeIPJk6y0nQEIUYgyEeP49QRyx7IXl0zohE/Twj2Una5pRjbYE7lCYXZHdV/xbkd8E/m 7ZD9oCBmAUVSWzTaDxUMnC8Wzki3PPM7IxOFoqMzIMnBvaQZqYGd2mYI6ej9ekQMPY9wje jStpnroB/mE2fnggirwpe1hG5Lkx6PQ= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-wMQg4hQ0Ppap9C8w61v_5A-1; Fri, 17 Jul 2020 10:18:10 -0400 X-MC-Unique: wMQg4hQ0Ppap9C8w61v_5A-1 Received: by mail-qv1-f69.google.com with SMTP id j4so5591160qvt.20 for ; Fri, 17 Jul 2020 07:18:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6nG6J4YezlYfGUG0e0ERTOm/9YYwGefzHEeAhTeysKE=; b=fK4VthFcXdr+Sl1AvRXF039nrSk4AwJS4tK2PIavL70iZJviGYXjBxa18ses4ZwMwh YdDW4uGDQtdybb88eM0Krbb0vc62GntejGI1o+xCdO9z1Uljb2sqHF3WbPTf2VhrjLIg g+awT303syURSBeTIcwPKS2SUWOoTRBiWI9QC1PgSD1JAn5uWATh6ZF+sWO6FNbAZsZc st8V2U5/11NVg5EbFYOnIgRW6XNlPuSktso0geb/Qhm5JJ9hz9fibrCj0FhT1LNH5Riq ys16aPoCKogT1xk/SgAPFqGSHivNN23EmA6QvXj5ggBjtpfmZzbFfRyCRvtV49nw5xR7 LPgw== X-Gm-Message-State: AOAM531G14Xj9jH4YjPDOmp7AEG8OcS7G299asWgR90dOy2krQKK32ef 7OqeacZIWI+1QsFftceJySW5m+ecN82/9irhnl18sQyZn/iAStPloRORGdVezvszWe2DNDi8c2E 1tYd+Lxbdab+Ci1k= X-Received: by 2002:ac8:72c4:: with SMTP id o4mr10294294qtp.270.1594995489754; Fri, 17 Jul 2020 07:18:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8O0kgglXi1Hac3yJ7GAI71LBCwvxh/hZUdtzeV4+GzOHgW5MefO32di9LUb7wcBpDjhTHEQ== X-Received: by 2002:ac8:72c4:: with SMTP id o4mr10294262qtp.270.1594995489398; Fri, 17 Jul 2020 07:18:09 -0700 (PDT) Received: from xz-x1 ([2607:9880:19c8:6f::1f4f]) by smtp.gmail.com with ESMTPSA id v184sm10488214qki.12.2020.07.17.07.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 07:18:08 -0700 (PDT) Date: Fri, 17 Jul 2020 10:18:06 -0400 From: Peter Xu To: Jason Wang Subject: Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier Message-ID: <20200717141806.GE535743@xz-x1> References: <20200707195429.GF88106@xz-x1> <5004a059-6eb0-4ef3-40b7-94dfbf9ec08f@redhat.com> <20200708141657.GA199122@xz-x1> <14b1ca26-448d-0feb-7529-6546809aaa59@redhat.com> <20200709141037.GF199122@xz-x1> <20200710133005.GL199122@xz-x1> <05bb512c-ca0a-e80e-1eed-446e918ad729@redhat.com> <20200716010005.GA535743@xz-x1> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/17 05:27:47 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Yan Zhao , "Michael S. Tsirkin" , "libvir-list@redhat.com" , Juan Quintela , qemu-devel@nongnu.org, Eugenio =?utf-8?B?UMOpcmV6?= , Eric Auger , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 16, 2020 at 10:54:31AM +0800, Jason Wang wrote: > > On 2020/7/16 上午9:00, Peter Xu wrote: > > On Mon, Jul 13, 2020 at 12:04:16PM +0800, Jason Wang wrote: > > > On 2020/7/10 下午9:30, Peter Xu wrote: > > > > On Fri, Jul 10, 2020 at 02:34:11PM +0800, Jason Wang wrote: > > > > > On 2020/7/9 下午10:10, Peter Xu wrote: > > > > > > On Thu, Jul 09, 2020 at 01:58:33PM +0800, Jason Wang wrote: > > > > > > > > > - If we care the performance, it's better to implement the MAP event for > > > > > > > > > vhost, otherwise it could be a lot of IOTLB miss > > > > > > > > I feel like these are two things. > > > > > > > > > > > > > > > > So far what we are talking about is whether vt-d should have knowledge about > > > > > > > > what kind of events one iommu notifier is interested in. I still think we > > > > > > > > should keep this as answered in question 1. > > > > > > > > > > > > > > > > The other question is whether we want to switch vhost from UNMAP to MAP/UNMAP > > > > > > > > events even without vDMA, so that vhost can establish the mapping even before > > > > > > > > IO starts. IMHO it's doable, but only if the guest runs DPDK workloads. When > > > > > > > > the guest is using dynamic iommu page mappings, I feel like that can be even > > > > > > > > slower, because then the worst case is for each IO we'll need to vmexit twice: > > > > > > > > > > > > > > > > - The first vmexit caused by an invalidation to MAP the page tables, so vhost > > > > > > > > will setup the page table before IO starts > > > > > > > > > > > > > > > > - IO/DMA triggers and completes > > > > > > > > > > > > > > > > - The second vmexit caused by another invalidation to UNMAP the page tables > > > > > > > > > > > > > > > > So it seems to be worse than when vhost only uses UNMAP like right now. At > > > > > > > > least we only have one vmexit (when UNMAP). We'll have a vhost translate() > > > > > > > > request from kernel to userspace, but IMHO that's cheaper than the vmexit. > > > > > > > Right but then I would still prefer to have another notifier. > > > > > > > > > > > > > > Since vtd_page_walk has nothing to do with device IOTLB. IOMMU have a > > > > > > > dedicated command for flushing device IOTLB. But the check for > > > > > > > vtd_as_has_map_notifier is used to skip the device which can do demand > > > > > > > paging via ATS or device specific way. If we have two different notifiers, > > > > > > > vhost will be on the device iotlb notifier so we don't need it at all? > > > > > > But we can still have iommu notifier that only registers to UNMAP even after we > > > > > > introduce dev-iotlb notifier? We don't want to do page walk for them as well. > > > > > > TCG should be the only one so far, but I don't know.. maybe there can still be > > > > > > new ones? > > > > > I think you're right. But looking at the codes, it looks like the check of > > > > > vtd_as_has_map_notifier() was only used in: > > > > > > > > > > 1) vtd_iommu_replay() > > > > > 2) vtd_iotlb_page_invalidate_notify() (PSI) > > > > > > > > > > For the replay, it's expensive anyhow. For PSI, I think it's just about one > > > > > or few mappings, not sure it will have obvious performance impact. > > > > > > > > > > And I had two questions: > > > > > > > > > > 1) The codes doesn't check map for DSI or GI, does this match what spec > > > > > said? (It looks to me the spec is unclear in this part) > > > > Both DSI/GI should cover maps too? E.g. vtd_sync_shadow_page_table() in > > > > vtd_iotlb_domain_invalidate(). > > > > > > I meant the code doesn't check whether there's an MAP notifier :) > > It's actually checked, because it loops over vtd_as_with_notifiers, and only > > MAP notifiers register to that. :) > > > I may miss something but I don't find the code to block UNMAP notifiers? > > vhost_iommu_region_add() >     memory_region_register_iommu_notifier() >         memory_region_update_iommu_notify_flags() >             imrc->notify_flag_changed() >                 vtd_iommu_notify_flag_changed() > > ? Yeah I think you're right. I might have confused with some previous implementations. Maybe we should also do similar thing for DSI/GI just like what we do in PSI. > > > > > 2) for the replay() I don't see other implementations (either spapr or > > > > > generic one) that did unmap (actually they skip unmap explicitly), any > > > > > reason for doing this in intel IOMMU? > > > > I could be wrong, but I'd guess it's because vt-d implemented the caching mode > > > > by leveraging the same invalidation strucuture, so it's harder to make all > > > > things right (IOW, we can't clearly identify MAP with UNMAP when we receive an > > > > invalidation request, because MAP/UNMAP requests look the same). > > > > > > > > I didn't check others, but I believe spapr is doing it differently by using > > > > some hypercalls to deliver IOMMU map/unmap requests, which seems a bit close to > > > > what virtio-iommu is doing. Anyway, the point is if we have explicit MAP/UNMAP > > > > from the guest, logically the replay indeed does not need to do any unmap > > > > because we don't need to call replay() on an already existing device but only > > > > for e.g. hot plug. > > > > > > But this looks conflict with what memory_region_iommu_replay( ) did, for > > > IOMMU that doesn't have a replay method, it skips UNMAP request: > > > > > >     for (addr = 0; addr < memory_region_size(mr); addr += granularity) { > > >         iotlb = imrc->translate(iommu_mr, addr, IOMMU_NONE, n->iommu_idx); > > >         if (iotlb.perm != IOMMU_NONE) { > > >             n->notify(n, &iotlb); > > >         } > > > > > > I guess there's no knowledge of whether guest have an explicit MAP/UMAP for > > > this generic code. Or replay implies that guest doesn't have explicit > > > MAP/UNMAP? > > I think it matches exactly with a hot plug case? Note that when IOMMU_NONE > > could also mean the translation does not exist. So it's actually trying to map > > everything that can be translated and then notify(). > > > Yes, so the question is what's the assumption before calling > memory_region_iommu_replay(). If it assumes an empty mapping, there's > probably no need for unamp. The only caller of memory_region_iommu_replay() is vfio_listener_region_add(), when there's a new vIOMMU memory region detected. So IIUC that guarantees the previous state should be all empty. Thanks, -- Peter Xu