* [PATCH] qdev: Document qdev_prop_set_drive_err() return value
@ 2020-07-20 12:16 Philippe Mathieu-Daudé
2020-07-20 12:36 ` no-reply
2020-07-22 7:20 ` Markus Armbruster
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-20 12:16 UTC (permalink / raw)
To: qemu-devel
Cc: Daniel P. Berrangé, Eduardo Habkost, qemu-trivial,
Philippe Mathieu-Daudé, Markus Armbruster, Paolo Bonzini
Since commit 73ac1aac39 qdev_prop_set_drive_err() returns
a boolean value. Document it.
Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void"
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
include/hw/qdev-properties.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 587e5b7d31..3a64d5ab9a 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
/*
* Set properties between creation and realization.
+ *
+ * Returns: %true on success, %false on error.
*/
bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
BlockBackend *value, Error **errp);
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value
2020-07-20 12:16 [PATCH] qdev: Document qdev_prop_set_drive_err() return value Philippe Mathieu-Daudé
@ 2020-07-20 12:36 ` no-reply
2020-07-22 7:20 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2020-07-20 12:36 UTC (permalink / raw)
To: f4bug; +Cc: qemu-devel, berrange, ehabkost, qemu-trivial, armbru, f4bug,
pbonzini
Patchew URL: https://patchew.org/QEMU/20200720121659.31886-1-f4bug@amsat.org/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
if qemu-system-x86_64 --help >/dev/null 2>&1; then
QEMU=qemu-system-x86_64
elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then
QEMU=/usr/libexec/qemu-kvm
else
exit 1
fi
make vm-build-freebsd J=21 QEMU=$QEMU
exit 0
=== TEST SCRIPT END ===
The full log is available at
http://patchew.org/logs/20200720121659.31886-1-f4bug@amsat.org/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qdev: Document qdev_prop_set_drive_err() return value
2020-07-20 12:16 [PATCH] qdev: Document qdev_prop_set_drive_err() return value Philippe Mathieu-Daudé
2020-07-20 12:36 ` no-reply
@ 2020-07-22 7:20 ` Markus Armbruster
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2020-07-22 7:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Paolo Bonzini, Daniel P. Berrangé, qemu-devel,
Eduardo Habkost
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Since commit 73ac1aac39 qdev_prop_set_drive_err() returns
> a boolean value. Document it.
>
> Fixes: 73ac1aac39 "Make functions taking Error ** return bool, not void"
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/qdev-properties.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 587e5b7d31..3a64d5ab9a 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -238,6 +238,8 @@ extern const PropertyInfo qdev_prop_pcie_link_width;
>
> /*
> * Set properties between creation and realization.
> + *
> + * Returns: %true on success, %false on error.
> */
> bool qdev_prop_set_drive_err(DeviceState *dev, const char *name,
> BlockBackend *value, Error **errp);
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-22 7:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-20 12:16 [PATCH] qdev: Document qdev_prop_set_drive_err() return value Philippe Mathieu-Daudé
2020-07-20 12:36 ` no-reply
2020-07-22 7:20 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).