From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 03/12] hw/arm/virt: Disable memory hotplug when MTE is enabled
Date: Mon, 20 Jul 2020 13:56:12 +0100 [thread overview]
Message-ID: <20200720125621.13460-4-peter.maydell@linaro.org> (raw)
In-Reply-To: <20200720125621.13460-1-peter.maydell@linaro.org>
From: Richard Henderson <richard.henderson@linaro.org>
When MTE is enabled, tag memory must exist for all RAM.
It might be possible to simultaneously hot plug tag memory
alongside the corresponding normal memory, but for now just
disable hotplug.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20200713213341.590275-4-richard.henderson@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/virt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index a7f3d442db3..ecfee362a18 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2194,6 +2194,11 @@ static void virt_memory_pre_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
return;
}
+ if (vms->mte) {
+ error_setg(errp, "memory hotplug is not enabled: MTE is enabled");
+ return;
+ }
+
if (is_nvdimm && !ms->nvdimms_state->is_enabled) {
error_setg(errp, "nvdimm is not enabled: add 'nvdimm=on' to '-M'");
return;
--
2.20.1
next prev parent reply other threads:[~2020-07-20 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 12:56 [PULL 00/12] target-arm queue Peter Maydell
2020-07-20 12:56 ` [PULL 01/12] hw/arm/virt: Enable MTE via a machine property Peter Maydell
2020-07-20 12:56 ` [PULL 02/12] hw/arm/virt: Error for MTE enabled with KVM Peter Maydell
2020-07-20 12:56 ` Peter Maydell [this message]
2020-07-20 12:56 ` [PULL 04/12] util: Implement qemu_get_thread_id() for OpenBSD Peter Maydell
2020-07-20 12:56 ` [PULL 05/12] qdev: Move doc comments from qdev.c to qdev-core.h Peter Maydell
2020-07-20 12:56 ` [PULL 06/12] qdev: Document qdev_unrealize() Peter Maydell
2020-07-20 12:56 ` [PULL 07/12] qdev: Document GPIO related functions Peter Maydell
2020-07-20 12:56 ` [PULL 08/12] hw/arm/armsse: Assert info->num_cpus is in-bounds in armsse_realize() Peter Maydell
2020-07-20 12:56 ` [PULL 09/12] docs/system: Briefly document canon-a1100 board Peter Maydell
2020-07-20 12:56 ` [PULL 10/12] docs/system: Briefly document collie board Peter Maydell
2020-07-20 12:56 ` [PULL 11/12] docs/system: Briefly document gumstix boards Peter Maydell
2020-07-20 12:56 ` [PULL 12/12] docs/system: Document the arm virt board Peter Maydell
2020-07-20 21:24 ` [PULL 00/12] target-arm queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720125621.13460-4-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).