From: svens@stackframe.org
To: Richard Henderson <richard.henderson@linaro.org>
Cc: deller@gmx.de, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH for-5.1] target/hppa: Free some temps in do_sub
Date: Mon, 20 Jul 2020 22:55:48 +0200 [thread overview]
Message-ID: <20200720205548.GB4591@t470p.stackframe.org> (raw)
In-Reply-To: <20200720174039.517902-1-richard.henderson@linaro.org>
Hi,
On Mon, Jul 20, 2020 at 10:40:39AM -0700, Richard Henderson wrote:
> Two temps allocated but not freed. Do enough subtractions
> within a single TB and one can run out of temps entirely.
>
> Cc: qemu-stable@nongnu.org
> Buglink: https://bugs.launchpad.net/qemu/+bug/1880287
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/hppa/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 52d7bea1ea..4bd22d4820 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -1294,6 +1294,8 @@ static void do_sub(DisasContext *ctx, unsigned rt, TCGv_reg in1,
> save_or_nullify(ctx, cpu_psw_cb_msb, cb_msb);
> save_gpr(ctx, rt, dest);
> tcg_temp_free(dest);
> + tcg_temp_free(cb);
> + tcg_temp_free(cb_msb);
>
> /* Install the new nullification. */
> cond_free(&ctx->null_cond);
> --
> 2.25.1
>
Tested-by: Sven Schnelle <svens@stackframe.org>
Regards
Sven
prev parent reply other threads:[~2020-07-20 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 17:40 [PATCH for-5.1] target/hppa: Free some temps in do_sub Richard Henderson
2020-07-20 17:48 ` Philippe Mathieu-Daudé
2020-07-20 20:55 ` svens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720205548.GB4591@t470p.stackframe.org \
--to=svens@stackframe.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).