From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-s390x@nongnu.org, "Tomáš Golembiovský" <tgolembi@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices
Date: Wed, 22 Jul 2020 06:40:24 +0200 [thread overview]
Message-ID: <20200722044028.4059-1-thuth@redhat.com> (raw)
The information that can be retrieved via UDEV is also usable for non-PCI
devices. So let's allow build_guest_fsinfo_for_real_device() on non-PCI
devices, too. This is required to fix the bug that CCW devices show up
without "Target" when running libvirt's "virsh domfsinfo" command (see
https://bugzilla.redhat.com/show_bug.cgi?id=1755075 for details).
v2:
- Use g_new0 instead of g_malloc0 (as suggested by Daniel)
- Init fields to -1 explicitely, not via memset (Daniel)
- Add the fourth patch to also fill in virtio information on s390x
Thomas Huth (4):
qga/qapi-schema: Document -1 for invalid PCI address fields
qga/commands-posix: Rework build_guest_fsinfo_for_real_device()
function
qga/commands-posix: Move the udev code from the pci to the generic
function
qga/commands-posix: Support fsinfo for non-PCI virtio devices, too
qga/commands-posix.c | 157 ++++++++++++++++++++++++++++++-------------
qga/qapi-schema.json | 2 +-
2 files changed, 110 insertions(+), 49 deletions(-)
--
2.18.1
next reply other threads:[~2020-07-22 4:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 4:40 Thomas Huth [this message]
2020-07-22 4:40 ` [PATCH v2 1/4] qga/qapi-schema: Document -1 for invalid PCI address fields Thomas Huth
2020-07-22 4:40 ` [PATCH v2 2/4] qga/commands-posix: Rework build_guest_fsinfo_for_real_device() function Thomas Huth
2020-07-22 9:19 ` Daniel P. Berrangé
2020-07-22 4:40 ` [PATCH v2 3/4] qga/commands-posix: Move the udev code from the pci to the generic function Thomas Huth
2020-07-22 9:18 ` Daniel P. Berrangé
2020-07-22 4:40 ` [PATCH v2 4/4] qga/commands-posix: Support fsinfo for non-PCI virtio devices, too Thomas Huth
2020-07-22 9:18 ` Daniel P. Berrangé
2020-07-27 23:29 ` [PATCH v2 0/4] Allow guest-get-fsinfo also for non-PCI devices Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722044028.4059-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).