From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B76C433E0 for ; Wed, 22 Jul 2020 16:18:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23CF8207BB for ; Wed, 22 Jul 2020 16:18:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LcMc6ciC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23CF8207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:45092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyHRn-000486-Ch for qemu-devel@archiver.kernel.org; Wed, 22 Jul 2020 12:18:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyHR1-0003i1-3N for qemu-devel@nongnu.org; Wed, 22 Jul 2020 12:17:35 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:60390 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyHQz-00044Z-CJ for qemu-devel@nongnu.org; Wed, 22 Jul 2020 12:17:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595434652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dMqbsxs0pSad1zLlqrFgJJVOeoosYhVkTfuV68iVT8Q=; b=LcMc6ciCirjOssLMybpmc/fgbUr41kvPMQyjm9jUMDQITtqKZMk/RsH3YsdWz1pFoA0zih zVPXwhljacTaU5hjeQrbsVQL5FaNU79lBnM12NdhGMiLNBCqtLXMj7HAJXuUTSzISs5xZJ z1xesjF2JqNNBgiYsfG0IMgVokYuWPE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-_MiA3ikDMkizZqUYpy0bvA-1; Wed, 22 Jul 2020 12:17:30 -0400 X-MC-Unique: _MiA3ikDMkizZqUYpy0bvA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 21A56100A8C4; Wed, 22 Jul 2020 16:17:29 +0000 (UTC) Received: from starship.redhat.com (unknown [10.35.206.82]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF3DD8BEC1; Wed, 22 Jul 2020 16:17:27 +0000 (UTC) From: Maxim Levitsky To: qemu-devel@nongnu.org Subject: [PATCH 1/1] pci/pcie: refuse another hotplug/unplug event if attention button is pending Date: Wed, 22 Jul 2020 19:17:22 +0300 Message-Id: <20200722161722.51416-2-mlevitsk@redhat.com> In-Reply-To: <20200722161722.51416-1-mlevitsk@redhat.com> References: <20200722161722.51416-1-mlevitsk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=mlevitsk@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/21 21:28:05 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxim Levitsky , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Curently it is possible to hotplug a device and then immediatly hotunplug it before the OS notices, and that will result in missed unplug event since we can only send one attention button event. Moreover the device will stuck in unplugging state forever. Error out in such cases and rely on the caller (e.g libvirt) to retry the unplug a bit later Signed-off-by: Maxim Levitsky --- hw/pci/pcie.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 5b48bae0f6..9e836cf2f4 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -402,6 +402,17 @@ static void pcie_cap_slot_plug_common(PCIDevice *hotplug_dev, DeviceState *dev, */ error_setg_errno(errp, EBUSY, "slot is electromechanically locked"); } + + if (sltsta & PCI_EXP_SLTSTA_ABP) { + /* + * Attention button is pressed, thus we can't send another + * hotpplug event + */ + error_setg_errno(errp, EBUSY, + "attention button is already pressed, can't " + "send another hotplug event"); + } + } void pcie_cap_slot_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, -- 2.26.2