From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7573AC433E3 for ; Thu, 23 Jul 2020 01:01:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D71220771 for ; Thu, 23 Jul 2020 01:01:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="a7g5Qskz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D71220771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyPcH-0001mO-Hj for qemu-devel@archiver.kernel.org; Wed, 22 Jul 2020 21:01:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyPav-0008QH-CJ; Wed, 22 Jul 2020 21:00:21 -0400 Received: from ozlabs.org ([203.11.71.1]:33559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyPat-0007HL-Cf; Wed, 22 Jul 2020 21:00:21 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4BBvBl0JXBz9sSd; Thu, 23 Jul 2020 11:00:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1595466015; bh=j7QHYI65DAAfvhiaUe+cigZivwhlPGe/EcQR9c5T6QE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a7g5QskzYnQhXpbR3330bYae+0cUsky834NMUaHnprn6o7fKmR934/ixahUuxfTXK DdzsmFHlsHHAnTbTCxIQiVQBF3uLT6n06d5RkkciOTMBActuH+sCvhgMpQ7bH0Io0c 7jYN5NLVHt4Xce0JAL7pvjgachU6KYaVfCpXZhVg= Date: Thu, 23 Jul 2020 10:57:07 +1000 From: David Gibson To: Thiago Jung Bauermann Subject: Re: [PATCH v2 5/9] mips/cps: Use start-powered-off CPUState property Message-ID: <20200723005707.GJ5513@umbus.fritz.box> References: <20200722035016.469075-1-bauerman@linux.ibm.com> <20200722035016.469075-6-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zYo4Elh1vtcYNvbq" Content-Disposition: inline In-Reply-To: <20200722035016.469075-6-bauerman@linux.ibm.com> Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/22 20:52:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Eduardo Habkost , Aleksandar Markovic , Cornelia Huck , Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Artyom Tarasenko , Thomas Huth , Paolo Bonzini , David Hildenbrand , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --zYo4Elh1vtcYNvbq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 22, 2020 at 12:50:12AM -0300, Thiago Jung Bauermann wrote: > Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the > start-powered-off property which makes cpu_common_reset() initialize it > to 1 in common code. >=20 > Signed-off-by: Thiago Jung Bauermann Reviewed-by: David Gibson > --- > hw/mips/cps.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > NB: I was only able to test that this patch builds. I wasn't able to > run it. >=20 > diff --git a/hw/mips/cps.c b/hw/mips/cps.c > index 615e1a1ad2..d5b6c78019 100644 > --- a/hw/mips/cps.c > +++ b/hw/mips/cps.c > @@ -52,9 +52,6 @@ static void main_cpu_reset(void *opaque) > CPUState *cs =3D CPU(cpu); > =20 > cpu_reset(cs); > - > - /* All VPs are halted on reset. Leave powering up to CPC. */ > - cs->halted =3D 1; > } > =20 > static bool cpu_mips_itu_supported(CPUMIPSState *env) > @@ -89,6 +86,9 @@ static void mips_cps_realize(DeviceState *dev, Error **= errp) > env->itc_tag =3D mips_itu_get_tag_region(&s->itu); > env->itu =3D &s->itu; > } > + /* All VPs are halted on reset. Leave powering up to CPC. */ > + object_property_set_bool(OBJECT(cpu), "start-powered-off", true, > + &error_abort); > qemu_register_reset(main_cpu_reset, cpu); > } > =20 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zYo4Elh1vtcYNvbq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl8Y4GMACgkQbDjKyiDZ s5JyAA//YW6V9OgSuH8HwzLeg/iqfCLU0uckSWxXFKHEeKOZVALxgz+G+LC0+mQO w8K15hVprkUqkHHeRM0tZbS2+iO+Zg4emNd+E8lRZ623lMJJmm6mBrV+0z5O1jK9 hjEMrIQkLj1XEO5ugqbdHKyN2iMZE+37sYYDaGbgQkwiVHvznicjjETfn5zihukF LPWRkjKmq9+IozQFd1x0MQZCcaqM6EQKO7K5p9csv4MHWPe79OYdW3U8MhQxo1y2 oDwrid8l6l00Z+54L2lSBRi9aZuHviz/A6wvxOWLoQmLSZX0RiT1Cp786CArwyCI jb4zIgnnfn+eCdM4LhUXY2xchum696P1J8lSJAJ/60ghMPpNF0q4+ogWBesIz9CG W9UHaDpUOJjxIUJiQiqaKfxQWUX/5BmE+faeII5rgiCRK0s9rufHIZO+ids4jnjl twyjfbAOPdb614CPV+Csoi5uv8eT/JOFodekvmypueWiMNOUXXltDmPd7gt3LMzf qNYJITIV++NeyJ/hTxGaZLIvM1PtVwGfbNTPuKT9bGwH7ZsCkMANdnSKVrLrShn5 YpmW+EMmo/NVl1rwBT0oLgcwie0R9bIXD2gqNfQPOLPPqOX2CwjPlb68NEkZc/r1 U8e9xBkI0x7htd5ma5+cvsxI592oj59a6j35/w1Y5/UtZy0EEQY= =HY4e -----END PGP SIGNATURE----- --zYo4Elh1vtcYNvbq--