qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	richard.henderson@linaro.org, f4bug@amsat.org,
	"Laurent Vivier" <laurent@vivier.eu>,
	cota@braap.org, aurelien@aurel32.net
Subject: [PATCH  v3 12/16] linux-user: fix clock_nanosleep()
Date: Fri, 24 Jul 2020 07:45:05 +0100	[thread overview]
Message-ID: <20200724064509.331-13-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200724064509.331-1-alex.bennee@linaro.org>

From: Laurent Vivier <laurent@vivier.eu>

If the call is interrupted by a signal handler, it fails with error EINTR
and if "remain" is not NULL and "flags" is not TIMER_ABSTIME, it returns
the remaining unslept time in "remain".

Update linux-user to not overwrite the "remain" structure if there is no
error.

Found with "make check-tcg", linux-test fails on nanosleep test:

  TEST    linux-test on x86_64
.../tests/tcg/multiarch/linux-test.c:242: nanosleep

Reported-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200722174612.2917566-2-laurent@vivier.eu>
---
 linux-user/syscall.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 1211e759c26..43a6e283961 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -11831,8 +11831,14 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
         target_to_host_timespec(&ts, arg3);
         ret = get_errno(safe_clock_nanosleep(arg1, arg2,
                                              &ts, arg4 ? &ts : NULL));
-        if (arg4)
+        /*
+         * if the call is interrupted by a signal handler, it fails
+         * with error -TARGET_EINTR and if arg4 is not NULL and arg2 is not
+         * TIMER_ABSTIME, it returns the remaining unslept time in arg4.
+         */
+        if (ret == -TARGET_EINTR && arg4 && arg2 != TIMER_ABSTIME) {
             host_to_target_timespec(arg4, &ts);
+        }
 
 #if defined(TARGET_PPC)
         /* clock_nanosleep is odd in that it returns positive errno values.
-- 
2.20.1



  parent reply	other threads:[~2020-07-24  6:53 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  6:44 [PATCH v3 00/16] candidate fixes for 5.1-rc1 (testing, semihosting, OOM tcg, x86 fpu) Alex Bennée
2020-07-24  6:44 ` [PATCH v3 01/16] shippable: add one more qemu to registry url Alex Bennée
2020-07-24  6:44 ` [PATCH v3 02/16] semihosting: defer connect_chardevs a little more to use serialx Alex Bennée
2020-07-24  6:44 ` [PATCH v3 03/16] semihosting: don't send the trailing '\0' Alex Bennée
2020-07-24  6:44 ` [PATCH v3 04/16] util: add qemu_get_host_physmem utility function Alex Bennée
2020-07-24  6:44 ` [PATCH v3 05/16] util/oslib-win32: add qemu_get_host_physmem implementation Alex Bennée
2020-07-24  6:51   ` Stefan Weil
2020-07-24  6:44 ` [PATCH v3 06/16] accel/tcg: better handle memory constrained systems Alex Bennée
2020-07-24 13:41   ` Robert Foley
2020-07-24 18:22   ` Richard Henderson
2020-07-24  6:45 ` [PATCH v3 07/16] target/i386: floatx80: avoid compound literals in static initializers Alex Bennée
2020-07-24 18:23   ` Richard Henderson
2020-07-24  6:45 ` [PATCH v3 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback Alex Bennée
2020-07-24  6:45 ` [PATCH v3 09/16] tests/docker: fix update command due to python3 str/bytes distinction Alex Bennée
2020-07-24  6:45 ` [PATCH v3 10/16] tests/docker: fix binfmt_misc image building Alex Bennée
2020-07-24  6:45 ` [PATCH v3 11/16] tests/docker: add support for DEB_KEYRING Alex Bennée
2020-07-24  6:45 ` Alex Bennée [this message]
2020-07-24 18:24   ` [PATCH v3 12/16] linux-user: fix clock_nanosleep() Richard Henderson
2020-07-24  6:45 ` [PATCH v3 13/16] linux-user, ppc: fix clock_nanosleep() for linux-user-ppc Alex Bennée
2020-07-24 18:24   ` [PATCH v3 13/16] linux-user,ppc: " Richard Henderson
2020-07-24  6:45 ` [PATCH v3 14/16] python/qemu: Cleanup changes to ConsoleSocket Alex Bennée
2020-07-24  7:25   ` Philippe Mathieu-Daudé
2020-07-24  6:45 ` [PATCH v3 15/16] python/qemu: Change ConsoleSocket to optionally drain socket Alex Bennée
2020-07-24  6:45 ` [PATCH v3 16/16] tests/vm: add shutdown timeout in basevm.py Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724064509.331-13-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).