From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [RFC PATCH] buildsys: Only build capstone if softmmu/user mode is enabled
Date: Fri, 24 Jul 2020 09:16:57 +0200 [thread overview]
Message-ID: <20200724071657.21508-1-f4bug@amsat.org> (raw)
At least one of softmmu or user mode has to be enabled to use
capstone. If not, don't clone/built it.
This save CI time for the tools/documentation-only build jobs.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
configure | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/configure b/configure
index 4bd80ed507..bc5757159a 100755
--- a/configure
+++ b/configure
@@ -5381,6 +5381,10 @@ fi
##########################################
# capstone
+if test -z "$capstone" && test $tcg = 'no' ; then # !tcg implies !softmmu
+ capstone="no"
+fi
+
case "$capstone" in
"" | yes)
if $pkg_config capstone; then
--
2.21.3
next reply other threads:[~2020-07-24 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:16 Philippe Mathieu-Daudé [this message]
2020-07-24 7:56 ` [RFC PATCH] buildsys: Only build capstone if softmmu/user mode is enabled Thomas Huth
2020-07-24 9:38 ` Philippe Mathieu-Daudé
2020-07-24 9:43 ` Thomas Huth
2020-07-24 9:46 ` Philippe Mathieu-Daudé
2020-07-24 9:59 ` Peter Maydell
2020-07-24 14:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724071657.21508-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).