From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Willian Rampazzo" <willianr@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule
Date: Fri, 24 Jul 2020 09:35:24 +0200 [thread overview]
Message-ID: <20200724073524.26589-3-f4bug@amsat.org> (raw)
In-Reply-To: <20200724073524.26589-1-f4bug@amsat.org>
The boot_linux.py file triggers an exception:
$ make fetch-acceptance
AVOCADO tests/acceptance
Fetching assets from tests/acceptance/empty_cpu_model.py.
Fetching assets from tests/acceptance/vnc.py.
Fetching assets from tests/acceptance/boot_linux_console.py.
Fetching assets from tests/acceptance/boot_linux.py.
Traceback (most recent call last):
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/__main__.py", line 11, in <module>
sys.exit(main.run())
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/core/app.py", line 91, in run
return method(self.parser.config)
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/plugins/assets.py", line 291, in run
success, fail = fetch_assets(test_file)
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/plugins/assets.py", line 200, in fetch_assets
handler = FetchAssetHandler(test_file, klass, method)
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/plugins/assets.py", line 65, in __init__
self.visit(self.tree)
File "/usr/lib64/python3.7/ast.py", line 271, in visit
return visitor(node)
File "/usr/lib64/python3.7/ast.py", line 279, in generic_visit
self.visit(item)
File "/usr/lib64/python3.7/ast.py", line 271, in visit
return visitor(node)
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/plugins/assets.py", line 139, in visit_ClassDef
self.generic_visit(node)
File "/usr/lib64/python3.7/ast.py", line 279, in generic_visit
self.visit(item)
File "/usr/lib64/python3.7/ast.py", line 271, in visit
return visitor(node)
File "/var/tmp/qemu-builddir/tests/venv/lib64/python3.7/site-packages/avocado/plugins/assets.py", line 171, in visit_Assign
self.asgmts[cur_klass][cur_method][name] = node.value.s
KeyError: 'launch_and_wait'
make: *** [tests/Makefile.include:949: fetch-acceptance] Error 1
Exclude it for now. We will revert this commit once the script is
fixed.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 238974d8da..7c9cf7a818 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -950,7 +950,7 @@ fetch-acceptance: check-venv
$(TESTS_VENV_DIR)/bin/python -m avocado \
$(if $(V),--show=$(AVOCADO_SHOW)) \
assets fetch \
- $(wildcard tests/acceptance/*.py), \
+ $(filter-out tests/acceptance/boot_linux.py,$(wildcard tests/acceptance/*.py)), \
"AVOCADO", "tests/acceptance")
check-acceptance: check-venv $(TESTS_RESULTS_DIR) get-vm-images
--
2.21.3
next prev parent reply other threads:[~2020-07-24 7:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:35 [PATCH 0/2] tests: Add 'fetch-acceptance' rule Philippe Mathieu-Daudé
2020-07-24 7:35 ` [PATCH 1/2] " Philippe Mathieu-Daudé
2020-07-24 19:00 ` Wainer dos Santos Moschetta
2020-07-24 7:35 ` Philippe Mathieu-Daudé [this message]
2020-07-24 18:26 ` [PATCH 2/2] tests: Exclude 'boot_linux.py' from fetch-acceptance rule Wainer dos Santos Moschetta
2020-07-24 18:47 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724073524.26589-3-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).