qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Li Qiang" <liq3ea@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Stefan Weil" <sw@weilnetz.de>
Subject: [PULL 3/4] sd/milkymist-memcard: Fix format string
Date: Fri, 24 Jul 2020 15:47:03 +0200	[thread overview]
Message-ID: <20200724134704.2248335-4-armbru@redhat.com> (raw)
In-Reply-To: <20200724134704.2248335-1-armbru@redhat.com>

From: Stefan Weil <sw@weilnetz.de>

Fixes: b98e8d1230ff7023bb34ddeb7194424dfcbaf789
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20200722204054.1400555-1-sw@weilnetz.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/sd/milkymist-memcard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
index afdb8aa0c0..11f61294fc 100644
--- a/hw/sd/milkymist-memcard.c
+++ b/hw/sd/milkymist-memcard.c
@@ -281,7 +281,7 @@ static void milkymist_memcard_realize(DeviceState *dev, Error **errp)
     carddev = qdev_new(TYPE_SD_CARD);
     qdev_prop_set_drive(carddev, "drive", blk);
     if (!qdev_realize_and_unref(carddev, BUS(&s->sdbus), &err)) {
-        error_propagate_prepend(errp, err, "failed to init SD card: %s");
+        error_propagate_prepend(errp, err, "failed to init SD card");
         return;
     }
     s->enabled = blk && blk_is_inserted(blk);
-- 
2.26.2



  parent reply	other threads:[~2020-07-24 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 13:47 [PULL 0/4] Error reporting patches patches for 2020-07-24 Markus Armbruster
2020-07-24 13:47 ` [PULL 1/4] coccinelle/err-bad-newline: Fix for Python 3, and add patterns Markus Armbruster
2020-07-24 13:47 ` [PULL 2/4] error: Strip trailing '\n' from error string arguments (again) Markus Armbruster
2020-07-24 13:47 ` Markus Armbruster [this message]
2020-07-24 13:47 ` [PULL 4/4] qapi/error: Check format string argument in error_*prepend() Markus Armbruster
2020-07-24 14:08   ` Daniel P. Berrangé
2020-07-24 15:06     ` Philippe Mathieu-Daudé
2020-07-25 16:23 ` [PULL 0/4] Error reporting patches patches for 2020-07-24 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724134704.2248335-4-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=liq3ea@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).