From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 624BFC433EA for ; Fri, 24 Jul 2020 14:40:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FB9120674 for ; Fri, 24 Jul 2020 14:40:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hq2tyWLZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FB9120674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyyrn-0005AA-9g for qemu-devel@archiver.kernel.org; Fri, 24 Jul 2020 10:40:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyyr0-0003w7-H7 for qemu-devel@nongnu.org; Fri, 24 Jul 2020 10:39:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:28531 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyyqy-0005hc-Pq for qemu-devel@nongnu.org; Fri, 24 Jul 2020 10:39:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595601556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BC5vj2jVGiXPIFp8wc3EHgX/0AN8Bj59g7u/hl368/Q=; b=Hq2tyWLZpOoSnONln1pv8/PhFUIB7i6yQmAZnor/j+NMNIAmcdHaMZp9wbC97qr+cJM8Bg /B8IHD40sSs3TaRaEb/XrtSZ3JEX+mU/fjPLVEmjighjVsPs18GHX8LGj22Bp6nWxbXq33 7Rn0Rl7wrkaewW7DL7GgiOYp7kOFQrA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230--zMXpxCtP8mdWsH8yGB17w-1; Fri, 24 Jul 2020 10:38:00 -0400 X-MC-Unique: -zMXpxCtP8mdWsH8yGB17w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5272D800597; Fri, 24 Jul 2020 14:37:59 +0000 (UTC) Received: from t480s.redhat.com (ovpn-113-94.ams2.redhat.com [10.36.113.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 44FA488F00; Fri, 24 Jul 2020 14:37:51 +0000 (UTC) From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH RFCv3 0/9] s390x: initial support for virtio-mem Date: Fri, 24 Jul 2020 16:37:41 +0200 Message-Id: <20200724143750.59836-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=david@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 08:55:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , "Michael S . Tsirkin" , Heiko Carstens , Cornelia Huck , David Hildenbrand , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Claudio Imbrenda , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This wires up the initial, basic version of virito-mem for s390x. General information about virtio-mem can be found at [1] and in QEMU commit [2]. Patch #5 contains a short example for s390x. virtio-mem for x86-64 Linux is part of v5.8-rc1. A branch with a s390x prototype can be found at: git@github.com:davidhildenbrand/linux.git virtio-mem-s390x Note that the kernel should either be compiled via CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE, or "memhp_default_state=online" should be passed on the kernel cmdline. This series can be found at: git@github.com:davidhildenbrand/qemu.git virtio-mem-s390x-rfcv3 Related to s390x, we'll have to tackle migration of storage keys and storage attributes (especially, maybe skipping unplugged parts). Not sure if I am missing something else (any ideas?). For virtio-mem in general, there are a couple of TODOs, e.g., documented in [1] and [2], both in QEMU and Linux. However, the basics are around. I only tested this with fairly small amount of RAM in a z/VM environemnt and under TCG ... [1] https://virtio-mem.gitlab.io/ [2] 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") RFCv2 -> RFCv3: - Use a new diag500 subcode to communicate the memory device region. Don't use diag260. Clarify why device memory is never exposed via other HW/firmware interface. (thanks Heiko for the discussion and looking into this!). This needed kernel changes (updated the Linux kernel branch) - Added -- "s390x: remove hypercall registration mechanism" -- "s390x: prepare for more diag500 hypercalls" -- "s390x: rename s390-virtio-hcall* to s390-hypercall*" -- "s390x/diag500: subcode to query device memory region" - "s390x: initial support for virtio-mem" -- Also wire-up virtio-mem-pci, although it does not seem to be compatible (yet?) due to MSI-X RFCv1 -> RFCv2: - "s390x/diag: no need to check for PGM_PRIVILEGED in diag308" -- Added - "s390x/diag: implement diag260" -- Implement according to doc (fix error cases) -- Implement subcode 0xc. -- Enable the new diag unconditionally - "s390x: prepare device memory address space" -- Expose maxram size now via diag260 (0xc), not via SCLP. Unfmodified guests can now boot without any issues. This needed kernel changes (updated the Linux kernel branch) - "s390x: implement virtio-mem-ccw" -- Force virtio revision 1 David Hildenbrand (9): s390x: move setting of maximum ram size to machine init s390x/diag: no need to check for PGM_PRIVILEGED in diag308 s390x: remove hypercall registration mechanism s390x: prepare for more diag500 hypercalls s390x: rename s390-virtio-hcall* to s390-hypercall* s390x/diag: subcode to query device memory region s390x: prepare device memory address space s390x: implement virtio-mem-ccw s390x: initial support for virtio-mem hw/s390x/Kconfig | 1 + hw/s390x/Makefile.objs | 3 +- hw/s390x/s390-hypercall.c | 79 +++++++++++ hw/s390x/s390-hypercall.h | 22 +++ hw/s390x/s390-virtio-ccw.c | 207 +++++++++++++++++++++++------ hw/s390x/s390-virtio-hcall.c | 41 ------ hw/s390x/s390-virtio-hcall.h | 23 ---- hw/s390x/sclp.c | 21 +-- hw/s390x/virtio-ccw-mem.c | 167 +++++++++++++++++++++++ hw/s390x/virtio-ccw.h | 13 ++ hw/virtio/virtio-mem.c | 2 + include/hw/s390x/s390-virtio-ccw.h | 3 + target/s390x/diag.c | 5 - target/s390x/kvm.c | 17 +-- target/s390x/misc_helper.c | 5 +- 15 files changed, 466 insertions(+), 143 deletions(-) create mode 100644 hw/s390x/s390-hypercall.c create mode 100644 hw/s390x/s390-hypercall.h delete mode 100644 hw/s390x/s390-virtio-hcall.c delete mode 100644 hw/s390x/s390-virtio-hcall.h create mode 100644 hw/s390x/virtio-ccw-mem.c -- 2.26.2