From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE565C433FB for ; Fri, 24 Jul 2020 13:28:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34450206D7 for ; Fri, 24 Jul 2020 13:28:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BzmATLT7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34450206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jyxkb-0004zF-72 for qemu-devel@archiver.kernel.org; Fri, 24 Jul 2020 09:28:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jyxjX-0003Px-HT for qemu-devel@nongnu.org; Fri, 24 Jul 2020 09:27:31 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:22800 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jyxjV-0001Ie-IM for qemu-devel@nongnu.org; Fri, 24 Jul 2020 09:27:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595597248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kTvgdrsghdP+0lgsecbrsLgM8RxDFIkv9el4pBO84VU=; b=BzmATLT7fSKRmJIBpL+ljTEKkGWb9odNDpLntBPtQz7frydqL4F7hpIosXU8jHkcXxaGX8 CT9wXpxhwmA0PQyCOUXiS6TGGBAq63qvr6KBz4h14S8lw9+v4H7MoAmeuv4AzHo6XLQLq+ Wl38ZSlNUjudzAzPQTulbADBC1p42Ag= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-400-XJx8tngsOsCeowBlXkwS5A-1; Fri, 24 Jul 2020 09:27:26 -0400 X-MC-Unique: XJx8tngsOsCeowBlXkwS5A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 125FF8017FB; Fri, 24 Jul 2020 13:27:26 +0000 (UTC) Received: from gondolin (ovpn-112-188.ams2.redhat.com [10.36.112.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19C81712C1; Fri, 24 Jul 2020 13:27:20 +0000 (UTC) Date: Fri, 24 Jul 2020 15:27:18 +0200 From: Cornelia Huck To: Jason Wang , "Michael S. Tsirkin" , Cindy Lu Subject: [BUG] vhost-vdpa: qemu-system-s390x crashes with second virtio-net-ccw device Message-ID: <20200724152718.4e1cbc9e.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/24 06:44:00 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" When I start qemu with a second virtio-net-ccw device (i.e. adding -device virtio-net-ccw in addition to the autogenerated device), I get a segfault. gdb points to #0 0x000055d6ab52681d in virtio_net_get_config (vdev=, config=0x55d6ad9e3f80 "RT") at /home/cohuck/git/qemu/hw/net/virtio-net.c:146 146 if (nc->peer->info->type == NET_CLIENT_DRIVER_VHOST_VDPA) { (backtrace doesn't go further) Starting qemu with no additional "-device virtio-net-ccw" (i.e., only the autogenerated virtio-net-ccw device is present) works. Specifying several "-device virtio-net-pci" works as well. Things break with 1e0a84ea49b6 ("vhost-vdpa: introduce vhost-vdpa net client"), 38140cc4d971 ("vhost_net: introduce set_config & get_config") works (in-between state does not compile). This is reproducible with tcg as well. Same problem both with --enable-vhost-vdpa and --disable-vhost-vdpa. Have not yet tried to figure out what might be special with virtio-ccw... anyone have an idea? [This should probably be considered a blocker?]