* [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines
@ 2020-07-24 16:52 Philippe Mathieu-Daudé
2020-07-30 11:34 ` Igor Mammedov
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-24 16:52 UTC (permalink / raw)
To: qemu-devel
Cc: Aleksandar Rikalo, qemu-trivial, Philippe Mathieu-Daudé,
Shannon Zhao, Aleksandar Markovic, Igor Mammedov, Aurelien Jarno
No MIPS machine uses the ACPI cpu-hotplug feature
(QEMU implementation is X86 specific).
Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
default-configs/mips-softmmu-common.mak | 1 -
1 file changed, 1 deletion(-)
diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
index da29c6c0b2..e9c208da3d 100644
--- a/default-configs/mips-softmmu-common.mak
+++ b/default-configs/mips-softmmu-common.mak
@@ -21,7 +21,6 @@ CONFIG_ACPI=y
CONFIG_ACPI_X86=y
CONFIG_ACPI_MEMORY_HOTPLUG=y
CONFIG_ACPI_NVDIMM=y
-CONFIG_ACPI_CPU_HOTPLUG=y
CONFIG_APM=y
CONFIG_I8257=y
CONFIG_PIIX4=y
--
2.21.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines
2020-07-24 16:52 [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines Philippe Mathieu-Daudé
@ 2020-07-30 11:34 ` Igor Mammedov
2020-08-03 16:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2020-07-30 11:34 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Aleksandar Rikalo, qemu-trivial, qemu-devel, Shannon Zhao,
Aleksandar Markovic, Aurelien Jarno
On Fri, 24 Jul 2020 18:52:59 +0200
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> No MIPS machine uses the ACPI cpu-hotplug feature
> (QEMU implementation is X86 specific).
if I recall correctly we were building it to satisfy symbol dependencies
due to hw/acpi/piix4.c being shared between x86 and mips.
It no longer the case?
> Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> default-configs/mips-softmmu-common.mak | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
> index da29c6c0b2..e9c208da3d 100644
> --- a/default-configs/mips-softmmu-common.mak
> +++ b/default-configs/mips-softmmu-common.mak
> @@ -21,7 +21,6 @@ CONFIG_ACPI=y
> CONFIG_ACPI_X86=y
> CONFIG_ACPI_MEMORY_HOTPLUG=y
> CONFIG_ACPI_NVDIMM=y
> -CONFIG_ACPI_CPU_HOTPLUG=y
> CONFIG_APM=y
> CONFIG_I8257=y
> CONFIG_PIIX4=y
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines
2020-07-30 11:34 ` Igor Mammedov
@ 2020-08-03 16:55 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-08-03 16:55 UTC (permalink / raw)
To: Igor Mammedov
Cc: Aleksandar Rikalo, qemu-trivial, qemu-devel, Shannon Zhao,
Aleksandar Markovic, Aurelien Jarno
On 7/30/20 1:34 PM, Igor Mammedov wrote:
> On Fri, 24 Jul 2020 18:52:59 +0200
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
>> No MIPS machine uses the ACPI cpu-hotplug feature
>> (QEMU implementation is X86 specific).
>
> if I recall correctly we were building it to satisfy symbol dependencies
> due to hw/acpi/piix4.c being shared between x86 and mips.
>
> It no longer the case?
Unfortunately you are right, it is still the case :(
>
>
>> Fixes: 135a67a692 ("ACPI: split CONFIG_ACPI into 4 pieces")
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> default-configs/mips-softmmu-common.mak | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/default-configs/mips-softmmu-common.mak b/default-configs/mips-softmmu-common.mak
>> index da29c6c0b2..e9c208da3d 100644
>> --- a/default-configs/mips-softmmu-common.mak
>> +++ b/default-configs/mips-softmmu-common.mak
>> @@ -21,7 +21,6 @@ CONFIG_ACPI=y
>> CONFIG_ACPI_X86=y
>> CONFIG_ACPI_MEMORY_HOTPLUG=y
>> CONFIG_ACPI_NVDIMM=y
>> -CONFIG_ACPI_CPU_HOTPLUG=y
>> CONFIG_APM=y
>> CONFIG_I8257=y
>> CONFIG_PIIX4=y
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-03 16:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-24 16:52 [PATCH-for-5.2] default-configs: Remove ACPI_CPU_HOTPLUG from MIPS machines Philippe Mathieu-Daudé
2020-07-30 11:34 ` Igor Mammedov
2020-08-03 16:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).