From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16A8BC433E1 for ; Mon, 27 Jul 2020 10:11:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D18A92070B for ; Mon, 27 Jul 2020 10:11:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IEw6a5ow" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D18A92070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k006v-0006tG-6R for qemu-devel@archiver.kernel.org; Mon, 27 Jul 2020 06:11:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k006K-0006PT-CN for qemu-devel@nongnu.org; Mon, 27 Jul 2020 06:11:20 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:38469 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k006I-0002II-N6 for qemu-devel@nongnu.org; Mon, 27 Jul 2020 06:11:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595844678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L1RXvpvbJUNqLsIsqGecdNIZwEbPFPSUSIdozP4PyYU=; b=IEw6a5owsitxkgZJE6X/sBs3M0BaMXZmbD3HIAD6AV8G/AtNjQjlGlhmBiJEqK2sztK/gS CimyauCFTnLYf7onu0YckPt76m5zVEoS834MwP9SlEm/CeqWjN+EzLsAf6F1SViorHmPad uMANQrqNOInIPu2Ul3WUOi4BjyEEsDo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-sCB1jdBpMA6Zc7zAtlmAOg-1; Mon, 27 Jul 2020 06:11:14 -0400 X-MC-Unique: sCB1jdBpMA6Zc7zAtlmAOg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA5AD80183C; Mon, 27 Jul 2020 10:11:12 +0000 (UTC) Received: from gondolin (ovpn-112-210.ams2.redhat.com [10.36.112.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id CE28310013D0; Mon, 27 Jul 2020 10:11:04 +0000 (UTC) Date: Mon, 27 Jul 2020 12:11:02 +0200 From: Cornelia Huck To: David Hildenbrand Subject: Re: [PATCH RFCv3 8/9] s390x: implement virtio-mem-ccw Message-ID: <20200727121102.12c5bc38.cohuck@redhat.com> In-Reply-To: References: <20200724143750.59836-1-david@redhat.com> <20200724143750.59836-9-david@redhat.com> <20200727115829.46fd241a.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/27 01:46:13 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , "Michael S . Tsirkin" , Heiko Carstens , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Claudio Imbrenda , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 27 Jul 2020 12:02:07 +0200 David Hildenbrand wrote: > On 27.07.20 11:58, Cornelia Huck wrote: > > On Fri, 24 Jul 2020 16:37:49 +0200 > > David Hildenbrand wrote: > > > >> Add a proper CCW proxy device, similar to the PCI variant. > >> > >> Signed-off-by: David Hildenbrand > >> --- > >> hw/s390x/virtio-ccw-mem.c | 167 ++++++++++++++++++++++++++++++++++++++ > >> hw/s390x/virtio-ccw.h | 13 +++ > >> 2 files changed, 180 insertions(+) > >> create mode 100644 hw/s390x/virtio-ccw-mem.c > > > > What happens on an old machine type -- I guess the device is just > > useless? > > Trying to plug will fail in the pre_plug stage via > > hw/mem/memory-device.c:memory_device_pre_plug()->memory_device_get_free_addr() > > with "memory devices (e.g. for memory hotplug) are not supported by the > machine" > > whereby never machines where "maxmem" was not properly specified will > result in > > "memory devices (e.g. for memory hotplug) are not enabled, please > specify the maxmem option" > Ah, sounds good :)