From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Robert Foley" <robert.foley@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Christian Ehrhardt" <christian.ehrhardt@canonical.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PULL 06/16] accel/tcg: better handle memory constrained systems
Date: Mon, 27 Jul 2020 13:23:47 +0100 [thread overview]
Message-ID: <20200727122357.31263-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200727122357.31263-1-alex.bennee@linaro.org>
It turns out there are some 64 bit systems that have relatively low
amounts of physical memory available to them (typically CI system).
Even with swapping available a 1GB translation buffer that fills up
can put the machine under increased memory pressure. Detect these low
memory situations and reduce tb_size appropriately.
Fixes: 600e17b2615 ("accel/tcg: increase default code gen buffer size for 64 bit")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Robert Foley <robert.foley@linaro.org>
Cc: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Message-Id: <20200724064509.331-7-alex.bennee@linaro.org>
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 2afa46bd2b1..2d83013633b 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -976,7 +976,12 @@ static inline size_t size_code_gen_buffer(size_t tb_size)
{
/* Size the buffer. */
if (tb_size == 0) {
- tb_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
+ size_t phys_mem = qemu_get_host_physmem();
+ if (phys_mem == 0) {
+ tb_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
+ } else {
+ tb_size = MIN(DEFAULT_CODE_GEN_BUFFER_SIZE, phys_mem / 8);
+ }
}
if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) {
tb_size = MIN_CODE_GEN_BUFFER_SIZE;
--
2.20.1
next prev parent reply other threads:[~2020-07-27 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 12:23 [PULL 00/16] various fixes for rc2 (semihosting, tcg, docker, tests/vm) Alex Bennée
2020-07-27 12:23 ` [PULL 01/16] shippable: add one more qemu to registry url Alex Bennée
2020-07-27 12:23 ` [PULL 02/16] semihosting: defer connect_chardevs a little more to use serialx Alex Bennée
2020-07-27 12:23 ` [PULL 03/16] semihosting: don't send the trailing '\0' Alex Bennée
2020-07-27 12:23 ` [PULL 04/16] util: add qemu_get_host_physmem utility function Alex Bennée
2020-07-27 12:23 ` [PULL 05/16] util/oslib-win32: add qemu_get_host_physmem implementation Alex Bennée
2020-07-27 12:23 ` Alex Bennée [this message]
2020-07-28 15:35 ` [PULL 06/16] accel/tcg: better handle memory constrained systems Christian Ehrhardt
2020-07-27 12:23 ` [PULL 07/16] target/i386: floatx80: avoid compound literals in static initializers Alex Bennée
2020-07-27 12:23 ` [PULL 08/16] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback Alex Bennée
2020-07-28 13:44 ` Peter Maydell
2020-07-28 16:04 ` Alex Bennée
2020-07-28 16:18 ` Peter Maydell
2020-07-27 12:23 ` [PULL 09/16] tests/docker: fix update command due to python3 str/bytes distinction Alex Bennée
2020-07-27 12:23 ` [PULL 10/16] tests/docker: fix binfmt_misc image building Alex Bennée
2020-07-27 12:23 ` [PULL 11/16] tests/docker: add support for DEB_KEYRING Alex Bennée
2020-07-27 12:23 ` [PULL 12/16] linux-user: fix clock_nanosleep() Alex Bennée
2020-07-27 12:23 ` [PULL 13/16] linux-user, ppc: fix clock_nanosleep() for linux-user-ppc Alex Bennée
2020-07-27 12:23 ` [PULL 14/16] python/qemu: Cleanup changes to ConsoleSocket Alex Bennée
2020-07-27 12:23 ` [PULL 15/16] python/qemu: Change ConsoleSocket to optionally drain socket Alex Bennée
2020-07-27 12:23 ` [PULL 16/16] tests/vm: add shutdown timeout in basevm.py Alex Bennée
2020-07-27 16:24 ` [PULL 00/16] various fixes for rc2 (semihosting, tcg, docker, tests/vm) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727122357.31263-7-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=christian.ehrhardt@canonical.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.foley@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).