From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jason Wang <jasowang@redhat.com>, Li Qiang <liq3ea@gmail.com>,
qemu-stable@nongnu.org, Cindy Lu <lulu@redhat.com>
Subject: [PULL 6/7] vhost-vdpa :Fix Coverity CID 1430270 / CID 1420267
Date: Mon, 27 Jul 2020 09:49:51 -0400 [thread overview]
Message-ID: <20200727134614.96376-7-mst@redhat.com> (raw)
In-Reply-To: <20200727134614.96376-1-mst@redhat.com>
From: Cindy Lu <lulu@redhat.com>
In the function vhost_vdpa_dma_map/unmap, The struct msg was not initialized all its fields.
Signed-off-by: Cindy Lu <lulu@redhat.com>
Message-Id: <20200710064642.24505-1-lulu@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/vhost-vdpa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 65d5aaf08a..4580f3efd8 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -37,7 +37,7 @@ static bool vhost_vdpa_listener_skipped_section(MemoryRegionSection *section)
static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr size,
void *vaddr, bool readonly)
{
- struct vhost_msg_v2 msg;
+ struct vhost_msg_v2 msg = {};
int fd = v->device_fd;
int ret = 0;
@@ -60,7 +60,7 @@ static int vhost_vdpa_dma_map(struct vhost_vdpa *v, hwaddr iova, hwaddr size,
static int vhost_vdpa_dma_unmap(struct vhost_vdpa *v, hwaddr iova,
hwaddr size)
{
- struct vhost_msg_v2 msg;
+ struct vhost_msg_v2 msg = {};
int fd = v->device_fd;
int ret = 0;
--
MST
next prev parent reply other threads:[~2020-07-27 13:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 13:49 [PULL 0/7] virtio,pci: bugfixes Michael S. Tsirkin
2020-07-27 13:49 ` [PULL 1/7] virtio-mem-pci: force virtio version 1 Michael S. Tsirkin
2020-07-27 13:49 ` [PULL 2/7] hw/pci-host: save/restore pci host config register Michael S. Tsirkin
2020-07-27 13:49 ` [PULL 3/7] hw/pci-host: save/restore pci host config register for old ones Michael S. Tsirkin
2020-07-27 13:49 ` [PULL 4/7] Fix vhost-user buffer over-read on ram hot-unplug Michael S. Tsirkin
2020-07-27 13:49 ` [PULL 5/7] libvhost-user: Report descriptor index on panic Michael S. Tsirkin
2020-07-27 13:49 ` Michael S. Tsirkin [this message]
2020-07-27 13:49 ` [PULL 7/7] MAINTAINERS: Cover the firmware JSON schema Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727134614.96376-7-mst@redhat.com \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=lulu@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).