From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Ed Maste" <emaste@freebsd.org>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>
Subject: Re: [PATCH v2 3/4] cirrus.yml: Compile macOS with -Werror
Date: Tue, 28 Jul 2020 11:04:36 +0100 [thread overview]
Message-ID: <20200728100436.GE3430616@redhat.com> (raw)
In-Reply-To: <20200728074405.13118-4-thuth@redhat.com>
On Tue, Jul 28, 2020 at 09:44:04AM +0200, Thomas Huth wrote:
> Compiler warnings currently go unnoticed in our macOS builds, since -Werror
> is only enabled for Linux and MinGW builds by default. So let's enable them
> here now, too.
> Unfortunately, the sasl header is marked as deprecated in the macOS headers
> and thus generates a lot of deprecation warnings. Thus we have to also use
> -Wno-error=deprecated-declarations to be able to compile the code here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .cirrus.yml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-07-28 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 7:44 [PATCH v2 0/4] Improve FreeBSD and macOS jobs in the Cirrus-CI Thomas Huth
2020-07-28 7:44 ` [PATCH v2 1/4] configure: Fix atomic64 test for --enable-werror on macOS Thomas Huth
2020-07-28 7:44 ` [PATCH v2 2/4] cirrus.yml: Compile FreeBSD with -Werror Thomas Huth
2020-07-28 10:05 ` Daniel P. Berrangé
2020-07-28 7:44 ` [PATCH v2 3/4] cirrus.yml: Compile macOS " Thomas Huth
2020-07-28 10:04 ` Daniel P. Berrangé [this message]
2020-07-28 7:44 ` [PATCH v2 4/4] cirrus.yml: Update the macOS jobs to Catalina Thomas Huth
2020-07-28 10:04 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728100436.GE3430616@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=emaste@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).