From: Greg Kurz <groug@kaod.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many()
Date: Tue, 28 Jul 2020 11:46:39 +0200 [thread overview]
Message-ID: <20200728114639.478a91e8@bahia.lan> (raw)
In-Reply-To: <8722268.CRvGb0V2lm@silver>
On Tue, 28 Jul 2020 11:34:12 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> On Dienstag, 28. Juli 2020 10:46:00 CEST Greg Kurz wrote:
> > > So I'll prepare a v8 with this patch here split into two.
> > >
> > > But this is it. I don't see another chunk in this patch set that could be
> > > split further down in an useful way.
> > >
> > > Best regards,
> > > Christian Schoenebeck
> >
> > You're in charge now so feel free to do that if the development+testing
> > cost is acceptable to you.
>
> Yep, that's the plan. This patch set is already thoroughly tested by me, so I
> would like to avoid major changes for this series now that would require me to
> restart major testing cycles.
>
> In this particular case, this patch-split ends up in 100% identical code. So
> it is really just git history tweaking after all.
>
> > You already know my take on having smaller
> > patches :)
>
> A pure desire for something is one thing, the actually available real-life
> options are another thing. If you see more options than I can identify, you
> are always invited to make your call.
>
> Plus this patch series already contain trivial patches for a long time (e.g.
> patch 1, 2, 6), and yet I haven't seen any ack from your side for any of them.
> Be invited for that as well.
>
I'm now starting to reach a steady-state in my new job. I should hopefully
be able to find some cycles for the trivial patches at least.
Thanks for your patience.
> Best regards,
> Christian Schoenebeck
>
>
next prev parent reply other threads:[~2020-07-28 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-19 13:43 [PATCH v7 0/6] 9pfs: readdir optimization Christian Schoenebeck
2020-07-19 11:20 ` [PATCH v7 1/6] tests/virtio-9p: added split readdir tests Christian Schoenebeck
2020-07-19 11:24 ` [PATCH v7 2/6] 9pfs: make v9fs_readdir_response_size() public Christian Schoenebeck
2020-07-19 12:29 ` [PATCH v7 3/6] 9pfs: add new function v9fs_co_readdir_many() Christian Schoenebeck
2020-07-28 8:33 ` Christian Schoenebeck
2020-07-28 8:46 ` Greg Kurz
2020-07-28 9:34 ` Christian Schoenebeck
2020-07-28 9:46 ` Greg Kurz [this message]
2020-07-19 13:11 ` [PATCH v7 4/6] 9pfs: T_readdir latency optimization Christian Schoenebeck
2020-07-19 13:20 ` [PATCH v7 5/6] 9pfs: differentiate readdir lock between 9P2000.u vs. 9P2000.L Christian Schoenebeck
2020-07-28 9:46 ` Christian Schoenebeck
2020-07-19 13:39 ` [PATCH v7 6/6] 9pfs: clarify latency of v9fs_co_run_in_worker() Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728114639.478a91e8@bahia.lan \
--to=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).