From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6EAC433E0 for ; Wed, 29 Jul 2020 19:23:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94D522068F for ; Wed, 29 Jul 2020 19:23:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=irrelevant.dk header.i=@irrelevant.dk header.b="g61+GWI+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94D522068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0rfr-0001Fo-Qv for qemu-devel@archiver.kernel.org; Wed, 29 Jul 2020 15:23:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0rfD-0000Wp-Ue; Wed, 29 Jul 2020 15:22:55 -0400 Received: from charlie.dont.surf ([128.199.63.193]:34316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0rf9-00045B-Ld; Wed, 29 Jul 2020 15:22:55 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id C4386BF616; Wed, 29 Jul 2020 19:22:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=irrelevant.dk; s=default; t=1596050569; bh=FGTqORHllUubxttiPoV6COY60GPcNImdo4SkTGJHLYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g61+GWI+FkcGlehy36P3De/2gJ59Ilq/geZRJFhSF143bm8/cjoSwxcQPXzNs7M68 rXVXunmKxnMCdPu+JA+By3iGOTKvqDWFszx0XFXKknm8f3T+cDYkaR9roYgByQxnaX 9VOos7/BUqv3l1L3hEQimcPzhTVyaAPsz/eCuv272OGvqKG+TGCJar1JZeUzXUEd6N TZnhmC96Nv4XBHCW7mE2Ph8z4RonFUkSNjMv6ta8DRGohPjYx5TLBVKiKvu42QD/aY Jk5G1DlukyAtlX5AfdReD+VqixUTTeTDdgr755kp+x9L4aVRUumpRh1+iUfiI9hRlO yWVdY3eVtkPOw== Date: Wed, 29 Jul 2020 21:22:45 +0200 From: Klaus Jensen To: Maxim Levitsky Subject: Re: [PATCH 07/16] hw/block/nvme: add request mapping helper Message-ID: <20200729192245.GA271829@apples.localdomain> References: <20200720113748.322965-1-its@irrelevant.dk> <20200720113748.322965-8-its@irrelevant.dk> <20200729155245.GF14876@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 14:23:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Minwoo Im , Keith Busch Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Jul 29 21:31, Maxim Levitsky wrote: > On Thu, 2020-07-30 at 00:52 +0900, Minwoo Im wrote: > > Klaus, > > > > On 20-07-20 13:37:39, Klaus Jensen wrote: > > > From: Klaus Jensen > > > > > > Introduce the nvme_map helper to remove some noise in the main nvme_rw > > > function. > > > > > > Signed-off-by: Klaus Jensen > > > Reviewed-by: Maxim Levitsky > > > --- > > > hw/block/nvme.c | 13 ++++++++++--- > > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > > index f1e04608804b..68c33a11c144 100644 > > > --- a/hw/block/nvme.c > > > +++ b/hw/block/nvme.c > > > @@ -413,6 +413,15 @@ static uint16_t nvme_dma_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len, > > > return status; > > > } > > > > > > +static uint16_t nvme_map(NvmeCtrl *n, NvmeCmd *cmd, size_t len, > > > + NvmeRequest *req) > > > > Can we specify what is going to be mapped in this function? like > > nvme_map_dptr? > I also once complained about the name, and I do like this idea! > Hehe. I will change it ;) Note that when I post support for metadata, it will have to change again! Because then the function will be mapping both DPTR and MPTR. But lets discuss naming when we get to that ;)