From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725DFC433DF for ; Wed, 29 Jul 2020 19:58:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F32920658 for ; Wed, 29 Jul 2020 19:58:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=irrelevant.dk header.i=@irrelevant.dk header.b="y+SdwYnR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F32920658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0sDP-0005gu-Jh for qemu-devel@archiver.kernel.org; Wed, 29 Jul 2020 15:58:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0sCn-00050m-K7; Wed, 29 Jul 2020 15:57:38 -0400 Received: from charlie.dont.surf ([128.199.63.193]:34404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0sCk-00086u-VI; Wed, 29 Jul 2020 15:57:36 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 45C96BF616; Wed, 29 Jul 2020 19:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=irrelevant.dk; s=default; t=1596052652; bh=GDEUIFzgcL+5zl8s2v3EUmWr5TyMvwsZyAaMVKBN3WI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y+SdwYnRY7U2c8rJv+SaSDFf2Z3pyrWLp6DBdACiocuzzXFmU2QZrxbkc41/nzSNK lFSBJu9brNE0B/i8/SMThknsBegMCwkaAhYfFCyLzK+dy0AquewPQT7MtLlpySiHtx yhA8hvVBuK41H0YTzOKVAJ9gVbi9o11FMgwV0wuzk3c1dClFzqpVbWoEEFwYL/h5sQ fsvQorKfLlH5e0swrIqHXj1BVdiuYF4/Px8E9nx5vHwAFGon6cYjQ7h51+XxUkt69I im63btE2SCjeNSJhwzFY87w4DssoUdmjiVC96B25pcX4nm2LFZTMj+wGh0Tfgvh27I 0hHTB2GdQnBWw== Date: Wed, 29 Jul 2020 21:57:30 +0200 From: Klaus Jensen To: Minwoo Im Subject: Re: [PATCH 16/16] hw/block/nvme: use preallocated qsg/iov in nvme_dma_prp Message-ID: <20200729195730.GD293496@apples.localdomain> References: <20200720113748.322965-1-its@irrelevant.dk> <20200720113748.322965-17-its@irrelevant.dk> <20200729161548.GO14876@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200729161548.GO14876@localhost.localdomain> Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 14:23:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Jul 30 01:15, Minwoo Im wrote: > On 20-07-20 13:37:48, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Since clean up of the request qsg/iov is now always done post-use, there > > is no need to use a stack-allocated qsg/iov in nvme_dma_prp. > > > > Signed-off-by: Klaus Jensen > > Acked-by: Keith Busch > > Reviewed-by: Maxim Levitsky > > > --- > > hw/block/nvme.c | 18 ++++++------------ > > 1 file changed, 6 insertions(+), 12 deletions(-) > > > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > > index 0b3dceccc89b..b6da5a9f3fc6 100644 > > --- a/hw/block/nvme.c > > +++ b/hw/block/nvme.c > > @@ -381,45 +381,39 @@ static uint16_t nvme_dma_prp(NvmeCtrl *n, uint8_t *ptr, uint32_t len, > > uint64_t prp1, uint64_t prp2, DMADirection dir, > > NvmeRequest *req) > > { > > - QEMUSGList qsg; > > - QEMUIOVector iov; > > uint16_t status = NVME_SUCCESS; > > > > - status = nvme_map_prp(n, &qsg, &iov, prp1, prp2, len, req); > > + status = nvme_map_prp(n, &req->qsg, &req->iov, prp1, prp2, len, req); > > After this change, can we make nvme_map_prp() just receive > NvmeRequest *req without &req->qsg, &req->iov by retrieve them from > inside of the nvme_map_prp()? Absolutely. I added a follow up patch to do this :)