From: Vivek Goyal <vgoyal@redhat.com>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, vromanso@redhat.com, dgilbert@redhat.com,
virtio-fs@redhat.com, stefanha@redhat.com, vgoyal@redhat.com
Subject: [PATCH 1/5] virtiofsd: Add notion of unprivileged mode
Date: Wed, 29 Jul 2020 18:14:06 -0400 [thread overview]
Message-ID: <20200729221410.147556-2-vgoyal@redhat.com> (raw)
In-Reply-To: <20200729221410.147556-1-vgoyal@redhat.com>
At startup if we are running as non-root user, then internall set
unpriviliged mode set. Also add a notion of sandbox NONE and set
that internally in unprivileged mode. setting up namespaces and
chroot() fails when one does not have privileges.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index e2fbc614fd..cd91c4a831 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -147,11 +147,13 @@ enum {
enum {
SANDBOX_NAMESPACE,
SANDBOX_CHROOT,
+ SANDBOX_NONE,
};
struct lo_data {
pthread_mutex_t mutex;
int sandbox;
+ bool unprivileged;
int debug;
int writeback;
int flock;
@@ -3288,6 +3290,12 @@ int main(int argc, char *argv[])
lo_map_init(&lo.dirp_map);
lo_map_init(&lo.fd_map);
+ if (geteuid() != 0) {
+ lo.unprivileged = true;
+ lo.sandbox = SANDBOX_NONE;
+ fuse_log(FUSE_LOG_DEBUG, "Running in unprivileged passthrough mode.\n");
+ }
+
if (fuse_parse_cmdline(&args, &opts) != 0) {
goto err_out1;
}
--
2.25.4
next prev parent reply other threads:[~2020-07-29 22:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 22:14 [RFC PATCH 0/5] virtiofsd: Add notion of unprivileged mode Vivek Goyal
2020-07-29 22:14 ` Vivek Goyal [this message]
2020-07-29 22:14 ` [PATCH 2/5] virtiofsd: create lock/pid file in per user cache dir Vivek Goyal
2020-07-30 8:59 ` Daniel P. Berrangé
2020-07-30 14:10 ` Vivek Goyal
2020-07-29 22:14 ` [PATCH 3/5] virtiofsd: open /proc/self/fd/ in sandbox=NONE mode Vivek Goyal
2020-07-29 22:14 ` [PATCH 4/5] virtiofsd: Open lo->source while setting up root " Vivek Goyal
2020-07-29 22:14 ` [PATCH 5/5] virtiofsd: Skip setup_capabilities() " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729221410.147556-2-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=vromanso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).