From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 183B9C433DF for ; Thu, 30 Jul 2020 11:31:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D98462074B for ; Thu, 30 Jul 2020 11:31:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MYwaSlv5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D98462074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k16mk-0002Tf-Vq for qemu-devel@archiver.kernel.org; Thu, 30 Jul 2020 07:31:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k16l3-0000qz-0I for qemu-devel@nongnu.org; Thu, 30 Jul 2020 07:29:57 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:39553 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k16l1-0005Wv-BR for qemu-devel@nongnu.org; Thu, 30 Jul 2020 07:29:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596108593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WZXuqWMMjM71taDLBLMznQua1y5/n6InfoamN+Iv7/Q=; b=MYwaSlv53pTMybak+Vir9+Luvib7VKzAAL591ij1Qq3OcXzWZCHjiuxhKkXqiCRIqwEhyD 7Fux4T1PM+JBC21Gql1vq9xYIKq0YWkHg+QLmfX7RGdJvBi6LxpK0T+SheY7SL5uA6oY9A OVgVTR1MClKg2jSIYmHlTLbJP6J5ymE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-g3Xy1SxEOwaam9tbAdRT2A-1; Thu, 30 Jul 2020 07:29:50 -0400 X-MC-Unique: g3Xy1SxEOwaam9tbAdRT2A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98AAC800FEA; Thu, 30 Jul 2020 11:29:48 +0000 (UTC) Received: from gondolin (ovpn-112-203.ams2.redhat.com [10.36.112.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id 117E45FC31; Thu, 30 Jul 2020 11:29:43 +0000 (UTC) Date: Thu, 30 Jul 2020 13:29:42 +0200 From: Cornelia Huck To: Halil Pasic Subject: Re: [PATCH 1/1] s390x/s390-virtio-ccw: fix off-by-one in loadparm getter Message-ID: <20200730132942.485b73c6.cohuck@redhat.com> In-Reply-To: <20200730132521.674ded34.pasic@linux.ibm.com> References: <20200729130222.29026-1-pasic@linux.ibm.com> <20200730122656.4942edbb.cohuck@redhat.com> <20200730132521.674ded34.pasic@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/30 03:59:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , David Hildenbrand , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 30 Jul 2020 13:25:21 +0200 Halil Pasic wrote: > On Thu, 30 Jul 2020 12:26:56 +0200 > Cornelia Huck wrote: > > > On Wed, 29 Jul 2020 15:02:22 +0200 > > Halil Pasic wrote: > > > > > As pointed out by Peter, g_memdup(ms->loadparm, sizeof(ms->loadparm) + 1) > > > reads one past of the end of ms->loadparm, so g_memdup() can not be used > > > here. > > > > > > Let's use malloc and memcpy instead! > > > > Hm, an alternative would be to use g_strndup(). What do you think? > > Sure. It is more concise and does exactly what we want. I'm not too > familiar with the string utility funcitons of glib, so it didn't jup > at me. > > Shall I spin a v2? Sounds good.