From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE535C433DF for ; Mon, 3 Aug 2020 11:38:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9749E206E2 for ; Mon, 3 Aug 2020 11:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UztDo5Ec" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9749E206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52752 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2YnD-0003GL-JZ for qemu-devel@archiver.kernel.org; Mon, 03 Aug 2020 07:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2YmV-0002nO-SM for qemu-devel@nongnu.org; Mon, 03 Aug 2020 07:37:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58155 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k2YmU-0007G0-7c for qemu-devel@nongnu.org; Mon, 03 Aug 2020 07:37:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596454645; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6fqlgli/T4g8W+eAe5ILuZnBiy1sMaSJFgYki/+R4Y=; b=UztDo5EcIgpmCmUPTswEhrD62tYGmEU3DA4x7pwNvx2ruP2curh+9tPmwe3WDFQ+s5oQC7 ilngk2d5GRMq+ZbkPN98wlBqr4e2T9XGU0CA6tKVnwogjOVmZzfWUAYhaX34omk0am0lH2 bV3vy1fMh+eWXBlV0gbSLC9B1tGEvq4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-7BmHByOiMuWhBumDZBcbpQ-1; Mon, 03 Aug 2020 07:37:12 -0400 X-MC-Unique: 7BmHByOiMuWhBumDZBcbpQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A16778015F3; Mon, 3 Aug 2020 11:37:11 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F8B310013C4; Mon, 3 Aug 2020 11:36:58 +0000 (UTC) Date: Mon, 3 Aug 2020 12:36:55 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: [PATCH] schemas: Add vim modeline Message-ID: <20200803113655.GI3670709@redhat.com> References: <20200729185024.121766-1-abologna@redhat.com> <87ime52wxd.fsf@dusky.pond.sub.org> <20200730093732.GB3477223@redhat.com> <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200730132446.GL3477223@redhat.com> <875za33ku1.fsf@dusky.pond.sub.org> <20200731150738.GB3660103@redhat.com> <03bb7822-20a0-2945-6c86-1d5f1b2a01d9@redhat.com> <20200731154429.GD3660103@redhat.com> <21cda868-85d3-77db-31d8-0248a5029318@redhat.com> MIME-Version: 1.0 In-Reply-To: <21cda868-85d3-77db-31d8-0248a5029318@redhat.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/03 01:24:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Jason Wang , Juan Quintela , Yuval Shaia , Markus Armbruster , Gerd Hoffmann , Andrea Bolognani , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , John Snow , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 03, 2020 at 10:41:22AM +0200, Paolo Bonzini wrote: > On 31/07/20 17:44, Daniel P. Berrangé wrote: > > I'd consider the runtime protocol separately. In terms of what's on the > > wire, we use genuine JSON format. The runtime problem is simply that JSON > > standard is useless when it comes to integers, leaving behaviour undefined > > in the standard if you exceed 53 bits of precision. So there's no way to > > reliably parse unsigned 64-bit integers. Given that QEMU needs to pass > > uint64 values, JSON was simply the wrong choice of format for QMP. > > JSON's 53-bit precision was not part of RFC4627, which was the JSON > specification in 2010. They say hindsight is 20/20, but referring to > RFC7159 which would come 4 years later is rewriting history, not hindsight. I wasn't refering to RFC7159. The problem of undefined integer precision with JSON came up right at the very start when QMP was first designed and implemented, and has come up again periodically ever since then. libvirt needed to do workarounds right at the start in 2009, in order to fully handle signed/unsigned 64-bit integers with QMP. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|