From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A267C433E0 for ; Mon, 3 Aug 2020 16:37:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 472D5206DA for ; Mon, 3 Aug 2020 16:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AHfQ9j/K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 472D5206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2dT0-000832-H5 for qemu-devel@archiver.kernel.org; Mon, 03 Aug 2020 12:37:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2dSG-0007Wk-HT for qemu-devel@nongnu.org; Mon, 03 Aug 2020 12:36:52 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55390 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k2dSE-0006qO-0E for qemu-devel@nongnu.org; Mon, 03 Aug 2020 12:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596472607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CqZGcYJ0kE821PavH6SlYAQZiXfzDXTGaWlLJ3Reamo=; b=AHfQ9j/KYU+35qawWo7IEud2sUFEmi5A/WZxMbdAVfOn7elTFS092vbPA/7yXFCHiPe9uI bxIjsCFHNBdDZRIOEVAC6Z/yFl9UdYCZWG1ZI4Wnkrle2y3I75kuYopRfEnX6EmH7IXyBo g4AKfOevwGwDOggM3mOmveUbDIIXHV0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-425-XIGucIf0O8qktGhp7NaPZg-1; Mon, 03 Aug 2020 12:36:46 -0400 X-MC-Unique: XIGucIf0O8qktGhp7NaPZg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6385B1940932; Mon, 3 Aug 2020 16:36:45 +0000 (UTC) Received: from linux.fritz.box (ovpn-113-125.ams2.redhat.com [10.36.113.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2685287E3D; Mon, 3 Aug 2020 16:36:30 +0000 (UTC) Date: Mon, 3 Aug 2020 18:36:29 +0200 From: Kevin Wolf To: Markus Armbruster Subject: Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline) Message-ID: <20200803163629.GA4187@linux.fritz.box> References: <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200730132446.GL3477223@redhat.com> <875za33ku1.fsf@dusky.pond.sub.org> <20200731150738.GB3660103@redhat.com> <2cf1a431-9d2c-8ad6-446e-f10b36219764@redhat.com> <87d048i1m2.fsf@dusky.pond.sub.org> <83bbe0b0-c5e0-e3b7-5ba1-5946098370d5@redhat.com> <87ft94klyl.fsf@dusky.pond.sub.org> <490a0786-73f3-411e-4dfe-8c2ae90de251@redhat.com> <87y2mvhg3k.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87y2mvhg3k.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=kwolf@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/03 02:09:19 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eduardo Habkost , qemu-block@nongnu.org, Juan Quintela , Jason Wang , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Yuval Shaia , Gerd Hoffmann , Andrea Bolognani , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Paolo Bonzini , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 03.08.2020 um 18:03 hat Markus Armbruster geschrieben: > Paolo Bonzini writes: > > This means the two parts might be considered separately: > > > > - replacing single-quote with double-quote strings > > > > - replacing # comments with // > > If all we want is decent editor support out of the box, then rename to > .py, and drop the modelines. No merge conflicts, no git-blame > pollution. > > To make the .py files actual Python, additionally rename the bool > literals. Much, much less churn than massaging all strings or all > comments. I guess I could get behind this one. File renames still have a cost, but it feels like it wouldn't be absurdly high at least. And that you actually occasionally paste schema parts into real Python code suggests that there would be even a small benefit in addition to the good syntax highlighting out of the box. I fully expect that we'd keep our existing parser instead of using an actual Python parser, because the existing code (a) exists and (b) is probably simpler than the resulting code. Kevin