From: Peter Collingbourne <pcc@google.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: Peter Collingbourne <pcc@google.com>
Subject: [PATCH] target/arm: Rename function disas_ldst_pac to disas_ld_pac
Date: Mon, 3 Aug 2020 17:27:11 -0700 [thread overview]
Message-ID: <20200804002712.27733-1-pcc@google.com> (raw)
The name disas_ldst_pac is misleading as it implies the existence
of authenticating store instructions, so rename it to avoid that
implication.
Signed-off-by: Peter Collingbourne <pcc@google.com>
---
target/arm/translate-a64.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 8c0764957c..749de2e509 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -3408,8 +3408,8 @@ static void disas_ldst_atomic(DisasContext *s, uint32_t insn,
* W: pre-indexing flag
* S: sign for imm9.
*/
-static void disas_ldst_pac(DisasContext *s, uint32_t insn,
- int size, int rt, bool is_vector)
+static void disas_ld_pac(DisasContext *s, uint32_t insn,
+ int size, int rt, bool is_vector)
{
int rn = extract32(insn, 5, 5);
bool is_wback = extract32(insn, 11, 1);
@@ -3562,7 +3562,7 @@ static void disas_ldst_reg(DisasContext *s, uint32_t insn)
disas_ldst_reg_roffset(s, insn, opc, size, rt, is_vector);
return;
default:
- disas_ldst_pac(s, insn, size, rt, is_vector);
+ disas_ld_pac(s, insn, size, rt, is_vector);
return;
}
break;
--
2.28.0.163.g6104cc2f0b6-goog
next reply other threads:[~2020-08-04 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 0:27 Peter Collingbourne [this message]
2020-08-04 9:34 ` [PATCH] target/arm: Rename function disas_ldst_pac to disas_ld_pac Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804002712.27733-1-pcc@google.com \
--to=pcc@google.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).