qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Weil <sw@weilnetz.de>,
	Wainer dos Santos Moschetta <wainersm@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets
Date: Tue,  4 Aug 2020 19:00:46 +0200	[thread overview]
Message-ID: <20200804170055.2851-3-thuth@redhat.com> (raw)
In-Reply-To: <20200804170055.2851-1-thuth@redhat.com>

The code currently fails to compile on 32-bit big endian targets:

 target/riscv/vector_helper.c: In function 'vext_clear':
 target/riscv/vector_helper.c:154:16: error: cast to pointer from integer
 of different size [-Werror=int-to-pointer-cast]
         memset((void *)((uintptr_t)tail & ~(7ULL)), 0, part1);
                ^
 target/riscv/vector_helper.c:155:16: error: cast to pointer from integer
 of different size [-Werror=int-to-pointer-cast]
         memset((void *)(((uintptr_t)tail + 8) & ~(7ULL)), 0, part2);
                ^
 cc1: all warnings being treated as errors

We should not use "long long" (i.e. 64-bit) values here to avoid the
problem. Switch to our QEMU_ALIGN_PTR_DOWN/UP macros instead.

Fixes: 751538d5da ("add vector stride load and store instructions")
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 target/riscv/vector_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 39f44d1029..793af99067 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -151,8 +151,8 @@ static void vext_clear(void *tail, uint32_t cnt, uint32_t tot)
     if (cnt % 8) {
         part1 = 8 - (cnt % 8);
         part2 = tot - cnt - part1;
-        memset((void *)((uintptr_t)tail & ~(7ULL)), 0, part1);
-        memset((void *)(((uintptr_t)tail + 8) & ~(7ULL)), 0, part2);
+        memset(QEMU_ALIGN_PTR_DOWN(tail, 8), 0, part1);
+        memset(QEMU_ALIGN_PTR_UP(tail, 8), 0, part2);
     } else {
         memset(tail, 0, part2);
     }
-- 
2.18.1



  parent reply	other threads:[~2020-08-04 17:05 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 17:00 [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
2020-08-04 17:00 ` [PATCH 01/11] virtio-mem: Correct format specifier mismatch for RISC-V Thomas Huth
2020-08-04 17:00 ` Thomas Huth [this message]
2020-08-04 17:34   ` [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets Richard Henderson
2020-08-04 17:46   ` Philippe Mathieu-Daudé
2020-08-05  8:45     ` Thomas Huth
2020-08-04 17:00 ` [PATCH 03/11] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-04 17:00 ` [PATCH 04/11] tests/Makefile: test-replication " Thomas Huth
2020-08-04 17:00 ` [PATCH 05/11] tests/Makefile: Only build usable targets during 'make check-build' Thomas Huth
2020-08-04 17:00 ` [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target Thomas Huth
2020-08-04 17:45   ` Richard Henderson
2020-08-04 17:51   ` Philippe Mathieu-Daudé
2020-08-12  9:47   ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 07/11] Get rid of the libqemustub.a remainders Thomas Huth
2020-08-04 17:46   ` Richard Henderson
2020-08-04 17:00 ` [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak" Thomas Huth
2020-08-04 17:50   ` Richard Henderson
2020-08-04 18:20     ` Thomas Huth
2020-08-12  9:47       ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 09/11] gitlab-ci: Add cross-compiling build tests Thomas Huth
2020-08-04 17:00 ` [PATCH 10/11] configure: Allow automatic WHPX detection Thomas Huth
2020-08-04 17:47   ` Philippe Mathieu-Daudé
2020-08-04 18:25   ` Stefan Weil
2020-08-04 17:00 ` [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Thomas Huth
2020-08-04 18:07   ` Philippe Mathieu-Daudé
2020-08-04 18:32   ` Stefan Weil
2020-08-05  6:28     ` Thomas Huth
2020-08-05  9:11     ` Daniel P. Berrangé
2020-08-05 12:54       ` 罗勇刚(Yonggang Luo)
2020-08-04 17:05 ` [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804170055.2851-3-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).