From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Weil <sw@weilnetz.de>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH 07/11] Get rid of the libqemustub.a remainders
Date: Tue, 4 Aug 2020 19:00:51 +0200 [thread overview]
Message-ID: <20200804170055.2851-8-thuth@redhat.com> (raw)
In-Reply-To: <20200804170055.2851-1-thuth@redhat.com>
libqemustub.a has been removed in commit ebedb37c8d ("Makefile: Remove
libqemustub.a"). Some remainders have been missed. Remove them now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
Makefile | 2 +-
scripts/coverity-scan/run-coverity-scan | 3 ---
tests/test-util-sockets.c | 3 ++-
3 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/Makefile b/Makefile
index c2120d8d48..13dd708c4a 100644
--- a/Makefile
+++ b/Makefile
@@ -726,7 +726,7 @@ virtiofsd$(EXESUF): $(virtiofsd-obj-y) libvhost-user.a $(COMMON_LDADDS)
$(call LINK, $^)
endif
-vhost-user-gpu$(EXESUF): $(vhost-user-gpu-obj-y) $(libvhost-user-obj-y) libqemuutil.a libqemustub.a
+vhost-user-gpu$(EXESUF): $(vhost-user-gpu-obj-y) $(libvhost-user-obj-y) libqemuutil.a
$(call LINK, $^)
ifdef CONFIG_VHOST_USER_INPUT
diff --git a/scripts/coverity-scan/run-coverity-scan b/scripts/coverity-scan/run-coverity-scan
index 03a791dec9..6eefb4b558 100755
--- a/scripts/coverity-scan/run-coverity-scan
+++ b/scripts/coverity-scan/run-coverity-scan
@@ -403,9 +403,6 @@ echo "Configuring..."
--enable-mpath --enable-libxml2 --enable-glusterfs \
--enable-virtfs --enable-zstd
-echo "Making libqemustub.a..."
-make libqemustub.a
-
echo "Running cov-build..."
rm -rf cov-int
mkdir cov-int
diff --git a/tests/test-util-sockets.c b/tests/test-util-sockets.c
index 2ca1e99f17..261dc48c03 100644
--- a/tests/test-util-sockets.c
+++ b/tests/test-util-sockets.c
@@ -64,7 +64,8 @@ int monitor_get_fd(Monitor *mon, const char *fdname, Error **errp)
return dup(mon_fd);
}
-/* Syms in libqemustub.a are discarded at .o file granularity.
+/*
+ * Syms of stubs in libqemuutil.a are discarded at .o file granularity.
* To replace monitor_get_fd() we must ensure everything in
* stubs/monitor.c is defined, to make sure monitor.o is discarded
* otherwise we get duplicate syms at link time.
--
2.18.1
next prev parent reply other threads:[~2020-08-04 17:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:00 [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
2020-08-04 17:00 ` [PATCH 01/11] virtio-mem: Correct format specifier mismatch for RISC-V Thomas Huth
2020-08-04 17:00 ` [PATCH 02/11] target/riscv/vector_helper: Fix build on 32-bit big endian targets Thomas Huth
2020-08-04 17:34 ` Richard Henderson
2020-08-04 17:46 ` Philippe Mathieu-Daudé
2020-08-05 8:45 ` Thomas Huth
2020-08-04 17:00 ` [PATCH 03/11] tests/Makefile: test-image-locking needs CONFIG_POSIX Thomas Huth
2020-08-04 17:00 ` [PATCH 04/11] tests/Makefile: test-replication " Thomas Huth
2020-08-04 17:00 ` [PATCH 05/11] tests/Makefile: Only build usable targets during 'make check-build' Thomas Huth
2020-08-04 17:00 ` [PATCH 06/11] tests/Makefile: Add $(EXESUF) to fp-test target Thomas Huth
2020-08-04 17:45 ` Richard Henderson
2020-08-04 17:51 ` Philippe Mathieu-Daudé
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` Thomas Huth [this message]
2020-08-04 17:46 ` [PATCH 07/11] Get rid of the libqemustub.a remainders Richard Henderson
2020-08-04 17:00 ` [PATCH 08/11] stubs/notify-event: Mark qemu_notify_event() stub as "weak" Thomas Huth
2020-08-04 17:50 ` Richard Henderson
2020-08-04 18:20 ` Thomas Huth
2020-08-12 9:47 ` Paolo Bonzini
2020-08-04 17:00 ` [PATCH 09/11] gitlab-ci: Add cross-compiling build tests Thomas Huth
2020-08-04 17:00 ` [PATCH 10/11] configure: Allow automatic WHPX detection Thomas Huth
2020-08-04 17:47 ` Philippe Mathieu-Daudé
2020-08-04 18:25 ` Stefan Weil
2020-08-04 17:00 ` [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Thomas Huth
2020-08-04 18:07 ` Philippe Mathieu-Daudé
2020-08-04 18:32 ` Stefan Weil
2020-08-05 6:28 ` Thomas Huth
2020-08-05 9:11 ` Daniel P. Berrangé
2020-08-05 12:54 ` 罗勇刚(Yonggang Luo)
2020-08-04 17:05 ` [PATCH 00/11] Run cross-compilation build tests in the gitlab-CI Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804170055.2851-8-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).