From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C022C433E0 for ; Wed, 5 Aug 2020 10:11:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31D6E207FC for ; Wed, 5 Aug 2020 10:11:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R4mHQR8g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31D6E207FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3GOI-00030F-G9 for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 06:11:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3GHh-0002Vj-43 for qemu-devel@nongnu.org; Wed, 05 Aug 2020 06:04:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:24162 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3GHe-0000mu-K3 for qemu-devel@nongnu.org; Wed, 05 Aug 2020 06:04:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596621869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ngCe1QFMoZDc5ieKEFMgDJErW0d3AtyhcBRCPnyFEb8=; b=R4mHQR8gpVga6c42ym5Aw6KX5fQu1YVV/aT9I5bCJGCLptdK7IGZRNfI97AaPtHcN+Drwv zLaibANZ7THp14AlOuWX6kJwAbx8mTTSQKBxroCPAdD6JPELaTxZAbfV6FbcZ4WKBuP+TW MHr1kGofKlsvLNXHTmqisHh1S3Y1S9s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-9zDT9YKrNU-y3wrAbLFhHQ-1; Wed, 05 Aug 2020 06:04:24 -0400 X-MC-Unique: 9zDT9YKrNU-y3wrAbLFhHQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C3A3106B242; Wed, 5 Aug 2020 10:04:22 +0000 (UTC) Received: from gondolin (ovpn-113-4.ams2.redhat.com [10.36.113.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A331760BF3; Wed, 5 Aug 2020 10:04:20 +0000 (UTC) Date: Wed, 5 Aug 2020 12:04:18 +0200 From: Cornelia Huck To: Thomas Huth Subject: Re: [PATCH for-5.2 6/6] pc-bios/s390-ccw: Allow booting in case the first virtio-blk disk is bad Message-ID: <20200805120418.072042c8.cohuck@redhat.com> In-Reply-To: <20200728183734.7838-7-thuth@redhat.com> References: <20200728183734.7838-1-thuth@redhat.com> <20200728183734.7838-7-thuth@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 00:45:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason J . Herne" , Collin Walling , Janosch Frank , qemu-devel@nongnu.org, Christian Borntraeger , qemu-s390x@nongnu.org, Claudio Imbrenda Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 28 Jul 2020 20:37:34 +0200 Thomas Huth wrote: > If you try to boot with two virtio-blk disks (without bootindex), and > only the second one is bootable, the s390-ccw bios currently stops at > the first disk and does not continue booting from the second one. This > is annoying - and all other major QEMU firmwares succeed to boot from > the second disk in this case, so we should do the same in the s390-ccw > bios, too. Does it make sense to do something like that for other device types as well? > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/bootmap.c | 34 +++++++++++++++++++++++----------- > pc-bios/s390-ccw/main.c | 2 +- > 2 files changed, 24 insertions(+), 12 deletions(-) Reviewed-by: Cornelia Huck