* [PATCH v5 1/2] hw/smbios: add options for type 4 max-speed and current-speed
2020-08-06 3:56 [PATCH v5 0/2] add new options to set smbios type 4 fields Ying Fang
@ 2020-08-06 3:56 ` Ying Fang
2020-08-06 3:56 ` [PATCH v5 2/2] tests/bios-tables-test: add smbios cpu speed test Ying Fang
2020-08-06 6:01 ` [PATCH v5 0/2] add new options to set smbios type 4 fields Michael S. Tsirkin
2 siblings, 0 replies; 5+ messages in thread
From: Ying Fang @ 2020-08-06 3:56 UTC (permalink / raw)
To: qemu-devel, imammedo, mst
Cc: lvivier, zhang.zhanghailiang, alex.chen, Ying Fang, Heyi Guo,
philmd
Common VM users sometimes care about CPU speed, so we add two new
options to allow VM vendors to present CPU speed to their users.
Normally these information can be fetched from host smbios.
Strictly speaking, the "max speed" and "current speed" in type 4
are not really for the max speed and current speed of processor, for
"max speed" identifies a capability of the system, and "current speed"
identifies the processor's speed at boot (see smbios spec), but some
applications do not tell the differences.
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Ying Fang <fangying1@huawei.com>
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
hw/smbios/smbios.c | 36 ++++++++++++++++++++++++++++++++----
qemu-options.hx | 2 +-
2 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 11d476c4a2..53181a58eb 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -93,9 +93,21 @@ static struct {
const char *manufacturer, *version, *serial, *asset, *sku;
} type3;
+/*
+ * SVVP requires max_speed and current_speed to be set and not being
+ * 0 which counts as unknown (SMBIOS 3.1.0/Table 21). Set the
+ * default value to 2000MHz as we did before.
+ */
+#define DEFAULT_CPU_SPEED 2000
+
static struct {
const char *sock_pfx, *manufacturer, *version, *serial, *asset, *part;
-} type4;
+ uint64_t max_speed;
+ uint64_t current_speed;
+} type4 = {
+ .max_speed = DEFAULT_CPU_SPEED,
+ .current_speed = DEFAULT_CPU_SPEED
+};
static struct {
size_t nvalues;
@@ -273,6 +285,14 @@ static const QemuOptDesc qemu_smbios_type4_opts[] = {
.name = "version",
.type = QEMU_OPT_STRING,
.help = "version number",
+ },{
+ .name = "max-speed",
+ .type = QEMU_OPT_NUMBER,
+ .help = "max speed in MHz",
+ },{
+ .name = "current-speed",
+ .type = QEMU_OPT_NUMBER,
+ .help = "speed at system boot in MHz",
},{
.name = "serial",
.type = QEMU_OPT_STRING,
@@ -587,9 +607,8 @@ static void smbios_build_type_4_table(MachineState *ms, unsigned instance)
SMBIOS_TABLE_SET_STR(4, processor_version_str, type4.version);
t->voltage = 0;
t->external_clock = cpu_to_le16(0); /* Unknown */
- /* SVVP requires max_speed and current_speed to not be unknown. */
- t->max_speed = cpu_to_le16(2000); /* 2000 MHz */
- t->current_speed = cpu_to_le16(2000); /* 2000 MHz */
+ t->max_speed = cpu_to_le16(type4.max_speed);
+ t->current_speed = cpu_to_le16(type4.current_speed);
t->status = 0x41; /* Socket populated, CPU enabled */
t->processor_upgrade = 0x01; /* Other */
t->l1_cache_handle = cpu_to_le16(0xFFFF); /* N/A */
@@ -1130,6 +1149,15 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
save_opt(&type4.serial, opts, "serial");
save_opt(&type4.asset, opts, "asset");
save_opt(&type4.part, opts, "part");
+ type4.max_speed = qemu_opt_get_number(opts, "max-speed",
+ DEFAULT_CPU_SPEED);
+ type4.current_speed = qemu_opt_get_number(opts, "current-speed",
+ DEFAULT_CPU_SPEED);
+ if (type4.max_speed > UINT16_MAX ||
+ type4.current_speed > UINT16_MAX) {
+ error_setg(errp, "SMBIOS CPU speed is too large (> %d)",
+ UINT16_MAX);
+ }
return;
case 11:
qemu_opts_validate(opts, qemu_smbios_type11_opts, &err);
diff --git a/qemu-options.hx b/qemu-options.hx
index ea0638e92d..50b068423c 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2073,7 +2073,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
" [,sku=str]\n"
" specify SMBIOS type 3 fields\n"
"-smbios type=4[,sock_pfx=str][,manufacturer=str][,version=str][,serial=str]\n"
- " [,asset=str][,part=str]\n"
+ " [,asset=str][,part=str][,max-speed=%d][,current-speed=%d]\n"
" specify SMBIOS type 4 fields\n"
"-smbios type=17[,loc_pfx=str][,bank=str][,manufacturer=str][,serial=str]\n"
" [,asset=str][,part=str][,speed=%d]\n"
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v5 2/2] tests/bios-tables-test: add smbios cpu speed test
2020-08-06 3:56 [PATCH v5 0/2] add new options to set smbios type 4 fields Ying Fang
2020-08-06 3:56 ` [PATCH v5 1/2] hw/smbios: add options for type 4 max-speed and current-speed Ying Fang
@ 2020-08-06 3:56 ` Ying Fang
2020-08-06 6:01 ` [PATCH v5 0/2] add new options to set smbios type 4 fields Michael S. Tsirkin
2 siblings, 0 replies; 5+ messages in thread
From: Ying Fang @ 2020-08-06 3:56 UTC (permalink / raw)
To: qemu-devel, imammedo, mst
Cc: lvivier, zhang.zhanghailiang, alex.chen, Ying Fang, Heyi Guo,
philmd
Add smbios type 4 CPU speed check for we added new options to set
smbios type 4 "max speed" and "current speed". The default value
should be 2000 when no option is specified, just as the old version
did.
We add the test case to one machine of each architecture, though it
doesn't really run on aarch64 platform for smbios test can't run on
uefi only platform yet.
Signed-off-by: Ying Fang <fangying1@huawei.com>
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
tests/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index a356ac3489..6bd165021b 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -37,6 +37,8 @@ typedef struct {
GArray *tables;
uint32_t smbios_ep_addr;
struct smbios_21_entry_point smbios_ep_table;
+ uint16_t smbios_cpu_max_speed;
+ uint16_t smbios_cpu_curr_speed;
uint8_t *required_struct_types;
int required_struct_types_len;
QTestState *qts;
@@ -516,6 +518,31 @@ static inline bool smbios_single_instance(uint8_t type)
}
}
+static bool smbios_cpu_test(test_data *data, uint32_t addr)
+{
+ uint16_t expect_speed[2];
+ uint16_t real;
+ int offset[2];
+ int i;
+
+ /* Check CPU speed for backward compatibility */
+ offset[0] = offsetof(struct smbios_type_4, max_speed);
+ offset[1] = offsetof(struct smbios_type_4, current_speed);
+ expect_speed[0] = data->smbios_cpu_max_speed ? : 2000;
+ expect_speed[1] = data->smbios_cpu_curr_speed ? : 2000;
+
+ for (i = 0; i < 2; i++) {
+ real = qtest_readw(data->qts, addr + offset[i]);
+ if (real != expect_speed[i]) {
+ fprintf(stderr, "Unexpected SMBIOS CPU speed: real %u expect %u\n",
+ real, expect_speed[i]);
+ return false;
+ }
+ }
+
+ return true;
+}
+
static void test_smbios_structs(test_data *data)
{
DECLARE_BITMAP(struct_bitmap, SMBIOS_MAX_TYPE+1) = { 0 };
@@ -538,6 +565,10 @@ static void test_smbios_structs(test_data *data)
}
set_bit(type, struct_bitmap);
+ if (type == 4) {
+ g_assert(smbios_cpu_test(data, addr));
+ }
+
/* seek to end of unformatted string area of this struct ("\0\0") */
prv = crt = 1;
while (prv || crt) {
@@ -673,6 +704,11 @@ static void test_acpi_q35_tcg(void)
data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
test_acpi_one(NULL, &data);
free_test_data(&data);
+
+ data.smbios_cpu_max_speed = 3000;
+ data.smbios_cpu_curr_speed = 2600;
+ test_acpi_one("-smbios type=4,max-speed=3000,current-speed=2600", &data);
+ free_test_data(&data);
}
static void test_acpi_q35_tcg_bridge(void)
@@ -885,6 +921,12 @@ static void test_acpi_virt_tcg(void)
test_acpi_one("-cpu cortex-a57", &data);
free_test_data(&data);
+
+ data.smbios_cpu_max_speed = 2900;
+ data.smbios_cpu_curr_speed = 2700;
+ test_acpi_one("-cpu cortex-a57 "
+ "-smbios type=4,max-speed=2900,current-speed=2700", &data);
+ free_test_data(&data);
}
int main(int argc, char *argv[])
--
2.23.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v5 0/2] add new options to set smbios type 4 fields
2020-08-06 3:56 [PATCH v5 0/2] add new options to set smbios type 4 fields Ying Fang
2020-08-06 3:56 ` [PATCH v5 1/2] hw/smbios: add options for type 4 max-speed and current-speed Ying Fang
2020-08-06 3:56 ` [PATCH v5 2/2] tests/bios-tables-test: add smbios cpu speed test Ying Fang
@ 2020-08-06 6:01 ` Michael S. Tsirkin
2020-08-06 6:58 ` Ying Fang
2 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2020-08-06 6:01 UTC (permalink / raw)
To: Ying Fang
Cc: lvivier, zhang.zhanghailiang, qemu-devel, alex.chen, imammedo,
philmd
On Thu, Aug 06, 2020 at 11:56:32AM +0800, Ying Fang wrote:
> From: fangying <fangying1@huawei.com>
>
> Hi, this patchset was previously posted by my teamate Heyi Guo several
> months ago, however we missed the merge window. It is reposted here to
> make it an end. Thanks.
Thanks, I will tag it for after the release.
Pls ping me after the release to make sure I don't drop it by mistake.
> Patch description:
>
> Common VM users sometimes care about CPU speed, so we add two new
> options to allow VM vendors to present CPU speed to their users.
> Normally these information can be fetched from host smbios.
>
> Strictly speaking, the "max speed" and "current speed" in type 4
> are not really for the max speed and current speed of processor, for
> "max speed" identifies a capability of the system, and "current speed"
> identifies the processor's speed at boot (see smbios spec), but some
> applications do not tell the differences.
>
> Changelog:
>
> v4 -> v5:
> - Rebase patch for lastest upstream
>
> v3 -> v4:
> - Fix the default value when not specifying "-smbios type=4" option;
> it would be 0 instead of 2000 in previous versions
> - Use uint64_t type to check value overflow
> - Add test case to check smbios type 4 CPU speed
> - v4 https://patchwork.kernel.org/cover/11444635/
>
> v2 -> v3:
> - Refine comments per Igor's suggestion.
>
> v1 -> v2:
> - change "_" in option names to "-"
> - check if option value is too large to fit in SMBIOS type 4 speed
> fields.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
>
> Ying Fang (2):
> hw/smbios: add options for type 4 max-speed and current-speed
> tests/bios-tables-test: add smbios cpu speed test
>
> hw/smbios/smbios.c | 36 ++++++++++++++++++++++++++++++----
> qemu-options.hx | 2 +-
> tests/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 75 insertions(+), 5 deletions(-)
>
> --
> 2.23.0
^ permalink raw reply [flat|nested] 5+ messages in thread