From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E59C433E0 for ; Fri, 7 Aug 2020 19:28:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23FA72074D for ; Fri, 7 Aug 2020 19:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DG1OETwV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23FA72074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52048 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k482k-0003z4-38 for qemu-devel@archiver.kernel.org; Fri, 07 Aug 2020 15:28:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k481r-00033w-Ro for qemu-devel@nongnu.org; Fri, 07 Aug 2020 15:27:47 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:22202 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k481o-00059U-VA for qemu-devel@nongnu.org; Fri, 07 Aug 2020 15:27:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596828462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cYz0cQYVjHEoaEQrHhj9L7BWhq3vTmA4NfH0UBP3/E=; b=DG1OETwVeaqKQr7zubXsox62rDVw/BLGNUMg98y3F+irS4JlDf3H5SvW98F6UUsWJQ7Vlg nsP9mlWB9Sy293Ur7wXyZ5JTKS3qWo+zRI1ThoxDfTQxmWZU8BpWwqaL8C0NHhMrCvBJPN m1r4mEWIR+4eR9pZwmgsCSfZ1r5hTzc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-a1Y0Af1IPpikUYpRwLVq4w-1; Fri, 07 Aug 2020 15:27:38 -0400 X-MC-Unique: a1Y0Af1IPpikUYpRwLVq4w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABA8658; Fri, 7 Aug 2020 19:27:37 +0000 (UTC) Received: from localhost (unknown [10.40.208.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 056445D9CA; Fri, 7 Aug 2020 19:27:32 +0000 (UTC) Date: Fri, 7 Aug 2020 21:27:29 +0200 From: Igor Mammedov To: Babu Moger Subject: Re: [PATCH v3 2/3] hw/i386: Add a new check to configure smp dies for EPYC Message-ID: <20200807212729.1cb2ede0@redhat.com> In-Reply-To: <159681797161.9679.5653247810916709875.stgit@naples-babu.amd.com> References: <159681772267.9679.1334429994189974662.stgit@naples-babu.amd.com> <159681797161.9679.5653247810916709875.stgit@naples-babu.amd.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=imammedo@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/07 04:00:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, mst@redhat.com, ehabkost@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 07 Aug 2020 11:32:51 -0500 Babu Moger wrote: > Adding a new check to warn the users to configure 'dies' when s/warn .../error out .../ > topology is numa configured. It makes it easy to build the > topology for EPYC models. probably it should mention that will break configs that do not have correct topology configured. > Signed-off-by: Babu Moger > --- > hw/i386/x86.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/i386/x86.c b/hw/i386/x86.c > index 67bee1bcb8..2a6ce56ef1 100644 > --- a/hw/i386/x86.c > +++ b/hw/i386/x86.c > @@ -138,6 +138,13 @@ void x86_cpus_init(X86MachineState *x86ms, int default_cpu_version) > > /* Check for apicid encoding */ > if (cpu_x86_use_epyc_apic_id_encoding(ms->cpu_type)) { > + if ((ms->numa_state->num_nodes > 0) && > + ms->numa_state->num_nodes != (ms->smp.sockets * x86ms->smp_dies)) { > + error_setg(&error_fatal, "Numa configuration requires smp 'dies' " > + "parameter. Configure the cpu topology properly with " > + "max_cpus = sockets * dies * cores * threads"); > + return; > + } > x86_set_epyc_topo_handlers(ms); > } we also should error out in case ms->numa_state->num_nodes != (ms->smp.sockets * x86ms->smp_dies and ask user to configure numa to match total number of used dies.