From: Hongzheng-Li <ethan.lee.qnl@gmail.com>
To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: Hou Weiying <weiying_hou@outlook.com>,
sagark@eecs.berkeley.edu, kbastian@mail.uni-paderborn.de,
Hongzheng-Li <Ethan.Lee.QNL@gmail.com>,
Alistair.Francis@wdc.com, palmer@dabbelt.com,
Myriad-Dreamin <camiyoru@gmail.com>
Subject: [PATCH 3/4] Add ePMP CSR accesses
Date: Sat, 8 Aug 2020 17:09:49 +0800 [thread overview]
Message-ID: <20200808090950.13-4-Ethan.Lee.QNL@gmail.com> (raw)
In-Reply-To: <20200808090950.13-1-Ethan.Lee.QNL@gmail.com>
From: Hou Weiying <weiying_hou@outlook.com>
Signed-off-by: Hongzheng-Li <Ethan.Lee.QNL@gmail.com>
Signed-off-by: Hou Weiying <weiying_hou@outlook.com>
Signed-off-by: Myriad-Dreamin <camiyoru@gmail.com>
---
target/riscv/csr.c | 18 ++++++++++++++++++
target/riscv/pmp.c | 40 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index 11d184cd16..e2395e3a51 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -112,6 +112,11 @@ static int hmode(CPURISCVState *env, int csrno)
return -1;
}
+static int epmp(CPURISCVState *env, int csrno)
+{
+ return -!(env->priv == PRV_M && riscv_feature(env, RISCV_FEATURE_EPMP));
+}
+
static int pmp(CPURISCVState *env, int csrno)
{
return -!riscv_feature(env, RISCV_FEATURE_PMP);
@@ -1160,6 +1165,18 @@ static int write_pmpaddr(CPURISCVState *env, int csrno, target_ulong val)
return 0;
}
+static int read_mseccfg(CPURISCVState *env, int csrno, target_ulong *val)
+{
+ *val = mseccfg_csr_read(env);
+ return 0;
+}
+
+static int write_mseccfg(CPURISCVState *env, int csrno, target_ulong val)
+{
+ mseccfg_csr_write(env, val);
+ return 0;
+}
+
#endif
/*
@@ -1368,6 +1385,7 @@ static riscv_csr_operations csr_ops[CSR_TABLE_SIZE] = {
[CSR_MTINST] = { hmode, read_mtinst, write_mtinst },
/* Physical Memory Protection */
+ [CSR_MSECCFG] = { epmp, read_mseccfg, write_mseccfg },
[CSR_PMPCFG0 ... CSR_PMPADDR9] = { pmp, read_pmpcfg, write_pmpcfg },
[CSR_PMPADDR0 ... CSR_PMPADDR15] = { pmp, read_pmpaddr, write_pmpaddr },
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 8df389cecd..0eabaf690c 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
@@ -490,3 +490,43 @@ target_ulong pmpaddr_csr_read(CPURISCVState *env, uint32_t addr_index)
return val;
}
+
+
+/*
+ * Handle a write to a mseccfg CSR
+ */
+void mseccfg_csr_write(CPURISCVState *env, target_ulong val)
+{
+ int i;
+
+ if (!MSECCFG_RLB_ISSET(env)) {
+ for (i = 0; i < MAX_RISCV_PMPS; i++) {
+ if (pmp_is_locked(env, i)) {
+ /*
+ * Now that mseccfg.rlb is zero
+ * the value of mseccfg.rlb should be locked.
+ */
+ val &= ~MSECCFG_RLB;
+ break;
+ }
+ }
+ }
+
+ /*
+ * sticky bit
+ */
+ val |= (env->mseccfg & (MSECCFG_MMWP | MSECCFG_MML));
+
+ env->mseccfg = val;
+ trace_mseccfg_csr_write(env->mhartid, val);
+}
+
+
+/*
+ * Handle a read from a mseccfg CSR
+ */
+target_ulong mseccfg_csr_read(CPURISCVState *env)
+{
+ trace_mseccfg_csr_read(env->mhartid, env->mseccfg);
+ return env->mseccfg;
+}
--
2.20.1
next prev parent reply other threads:[~2020-08-08 13:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-08 9:09 [PATCH 0/4] riscv: Add enhanced PMP support Hongzheng-Li
2020-08-08 9:09 ` [PATCH 1/4] Define ePMP mseccfg Hongzheng-Li
2020-08-08 9:09 ` [PATCH 2/4] Implementation of enhanced PMP(ePMP) support Hongzheng-Li
2020-08-08 9:09 ` Hongzheng-Li [this message]
2020-08-08 9:09 ` [PATCH 4/4] Add a config option for ePMP Hongzheng-Li
[not found] <20200808085656.28692-1-weiying_hou@outlook.com>
2020-08-08 8:56 ` [PATCH 3/4] Add ePMP CSR accesses Hou Weiying
[not found] <20200808052031.19523-1-weiying_hou@outlook.com>
2020-08-08 5:20 ` Hou Weiying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200808090950.13-4-Ethan.Lee.QNL@gmail.com \
--to=ethan.lee.qnl@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=camiyoru@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
--cc=weiying_hou@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).