qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Andrey Konovalov <andreyknvl@google.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	alex.bennee@linaro.org, peter.maydell@linaro.org
Subject: [PATCH 1/3] target/arm: Export merge_syn_data_abort from tlb_helper.c
Date: Wed, 12 Aug 2020 10:19:44 -0700	[thread overview]
Message-ID: <20200812171946.2044791-2-richard.henderson@linaro.org> (raw)
In-Reply-To: <20200812171946.2044791-1-richard.henderson@linaro.org>

We will shortly need this function in mte_helper.c.
It's also a bit too large for inlining, for something
that is on an exceptional path.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/internals.h  | 4 ++++
 target/arm/tlb_helper.c | 8 +++-----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/target/arm/internals.h b/target/arm/internals.h
index ae99725d2b..967d1319de 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -500,6 +500,10 @@ static inline uint32_t syn_wfx(int cv, int cond, int ti, bool is_16bit)
            (cv << 24) | (cond << 20) | ti;
 }
 
+uint32_t merge_syn_data_abort(uint32_t template_syn, unsigned int target_el,
+                              bool same_el, bool ea, bool s1ptw,
+                              bool is_write, int fsc);
+
 /* Update a QEMU watchpoint based on the information the guest has set in the
  * DBGWCR<n>_EL1 and DBGWVR<n>_EL1 registers.
  */
diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
index b35dc8a011..e8cf39f7d9 100644
--- a/target/arm/tlb_helper.c
+++ b/target/arm/tlb_helper.c
@@ -10,11 +10,9 @@
 #include "internals.h"
 #include "exec/exec-all.h"
 
-static inline uint32_t merge_syn_data_abort(uint32_t template_syn,
-                                            unsigned int target_el,
-                                            bool same_el, bool ea,
-                                            bool s1ptw, bool is_write,
-                                            int fsc)
+uint32_t merge_syn_data_abort(uint32_t template_syn, unsigned int target_el,
+                              bool same_el, bool ea, bool s1ptw,
+                              bool is_write, int fsc)
 {
     uint32_t syn;
 
-- 
2.25.1



  reply	other threads:[~2020-08-12 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-12 17:19 [PATCH 0/3] target/arm: Complete ISS for MTE tag check fail Richard Henderson
2020-08-12 17:19 ` Richard Henderson [this message]
2020-08-12 17:19 ` [PATCH 2/3] target/arm: Pass the entire mte descriptor to mte_check_fail Richard Henderson
2020-08-12 17:19 ` [PATCH 3/3] target/arm: Merge ISS for data abort from tag check fail Richard Henderson
2020-08-12 17:38 ` [PATCH 0/3] target/arm: Complete ISS for MTE " Andrey Konovalov
2020-08-12 17:52   ` Richard Henderson
2020-08-12 18:00     ` Richard Henderson
2020-08-12 18:02     ` Andrey Konovalov
2020-08-12 19:06       ` Evgenii Stepanov
2020-08-13 10:01         ` Kevin Brodsky
2020-08-13 12:26           ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200812171946.2044791-2-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=andreyknvl@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).