From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v2 1/3] hw/misc/unimp: Display value after offset
Date: Wed, 12 Aug 2020 21:02:04 +0200 [thread overview]
Message-ID: <20200812190206.31595-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200812190206.31595-1-f4bug@amsat.org>
To better align the read/write accesses, display the value after
the offset (read accesses only display the offset).
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/misc/unimp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c
index bc4084d344..ee2e536c8b 100644
--- a/hw/misc/unimp.c
+++ b/hw/misc/unimp.c
@@ -22,7 +22,7 @@ static uint64_t unimp_read(void *opaque, hwaddr offset, unsigned size)
{
UnimplementedDeviceState *s = UNIMPLEMENTED_DEVICE(opaque);
- qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read "
+ qemu_log_mask(LOG_UNIMP, "%s: unimplemented device read "
"(size %d, offset 0x%" HWADDR_PRIx ")\n",
s->name, size, offset);
return 0;
@@ -34,9 +34,9 @@ static void unimp_write(void *opaque, hwaddr offset,
UnimplementedDeviceState *s = UNIMPLEMENTED_DEVICE(opaque);
qemu_log_mask(LOG_UNIMP, "%s: unimplemented device write "
- "(size %d, value 0x%" PRIx64
- ", offset 0x%" HWADDR_PRIx ")\n",
- s->name, size, value, offset);
+ "(size %d, offset 0x%" HWADDR_PRIx
+ ", value 0x%" PRIx64 ")\n",
+ s->name, size, offset, value);
}
static const MemoryRegionOps unimp_ops = {
--
2.21.3
next prev parent reply other threads:[~2020-08-12 19:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 19:02 [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed Philippe Mathieu-Daudé
2020-08-12 19:02 ` Philippe Mathieu-Daudé [this message]
2020-08-12 19:02 ` [PATCH v2 2/3] hw/misc/unimp: Display the value with width of the access size Philippe Mathieu-Daudé
2020-08-12 19:02 ` [PATCH v2 3/3] hw/misc/unimp: Display the offset with width of the region size Philippe Mathieu-Daudé
2020-08-22 20:02 ` [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed Philippe Mathieu-Daudé
2020-08-24 15:01 ` Peter Maydell
2020-08-26 9:54 ` Philippe Mathieu-Daudé
2020-08-26 9:56 ` Philippe Mathieu-Daudé
2020-08-27 12:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812190206.31595-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).