From: David Gibson <david@gibson.dropbear.id.au>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
qemu-ppc@nongnu.org, clg@kaod.org,
Gustavo Romero <gromero@linux.ibm.com>
Subject: Re: [PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40
Date: Thu, 13 Aug 2020 10:03:21 +1000 [thread overview]
Message-ID: <20200813000321.GA17532@yekko.fritz.box> (raw)
In-Reply-To: <5944440c-73ac-8c21-9f02-fee91a3a2dfd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
On Wed, Aug 12, 2020 at 02:33:33PM -0700, Richard Henderson wrote:
> On 8/11/20 8:32 AM, Gustavo Romero wrote:
> > Currently if option '-icount auto' is passed to the QEMU TCG to enable
> > counting instructions the VM crashes with the following error report when
> > Linux runs on it:
> >
> > qemu-system-ppc64: Bad icount read
> >
> > This happens because read/write access to the SPRs PURR, VTB, and TBU40
> > is not integrated to the icount framework.
> >
> > This commit fixes that issue by making the read/write access of these
> > SPRs aware of icount framework, adding the proper gen_io_start() calls
> > before calling the helpers to load/store these SPRs in TCG and ensuring
> > that the associated TBs end immediately after, accordingly to what's in
> > docs/devel/tcg-icount.rst.
> >
> > Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
> > ---
> > target/ppc/translate_init.inc.c | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-5.2, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-13 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 15:32 [PATCH v2] target/ppc: Integrate icount to purr, vtb, and tbu40 Gustavo Romero
2020-08-12 21:33 ` Richard Henderson
2020-08-13 0:03 ` David Gibson [this message]
2020-08-13 2:42 ` Gustavo Romero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813000321.GA17532@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=gromero@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).